fix(bootstrap): Prevent recursive execution from all install lifecycles

lerna · Jan 8, 2019 · ea9dbbe · ea9dbbe
1 parent e602838
commit ea9dbbe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/commands/bootstrap/__tests__/bootstrap-command.test.js b/commands/bootstrap/__tests__/bootstrap-command.test.js
@@ -134,10 +134,17 @@ describe("BootstrapCommand", () => {
       expect(runLifecycle).not.toHaveBeenCalled();
     });
 
-    it("should not recurse from root install lifecycle", async () => {
+    test.each`
+      event
+      ${"preinstall"}
+      ${"install"}
+      ${"postinstall"}
+      ${"prepublish"}
+      ${"prepare"}
+    `("should not recurse from root $event lifecycle", async ({ event }) => {
       const testDir = await initFixture("lifecycle-scripts");
 
-      process.env.npm_lifecycle_event = "install";
+      process.env.npm_lifecycle_event = event;
 
       await lernaBootstrap(testDir)();
 

diff --git a/commands/bootstrap/index.js b/commands/bootstrap/index.js
@@ -98,9 +98,9 @@ class BootstrapCommand extends Command {
     }
 
     // don't execute recursively if run from a poorly-named script
-    this.runRootLifecycle = /^(pre|post)?install$/.test(process.env.npm_lifecycle_event)
+    this.runRootLifecycle = /^(prepare|prepublish|(pre|post)?install)$/.test(process.env.npm_lifecycle_event)
       ? stage => {
-          this.logger.warn("lifecycle", "Skipping root %j because it has already been called", stage);
+          this.logger.info("lifecycle", "Skipping root %j because it has already been called", stage);
         }
       : stage => this.runPackageLifecycle(this.project.manifest, stage);