fix(create): Pass options snapshot to pacote.manifest()

lerna · Dec 19, 2018 · 6116680 · 6116680
1 parent 11c583c
commit 6116680
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/commands/create/__tests__/create-command.test.js b/commands/create/__tests__/create-command.test.js
@@ -6,7 +6,6 @@ const fs = require("fs-extra");
 const path = require("path");
 const execa = require("execa");
 const slash = require("slash");
-const { Conf } = require("@lerna/npm-conf");
 
 // mocked modules
 const getManifest = require("libnpm/manifest");
@@ -131,7 +130,10 @@ describe("CreateCommand", () => {
         type: "tag",
         fetchSpec: "latest",
       }),
-      expect.any(Conf)
+      expect.objectContaining({
+        // an npm-conf snapshot
+        registry: "https://registry.npmjs.org/",
+      })
     );
   });
 

diff --git a/commands/create/index.js b/commands/create/index.js
@@ -229,6 +229,7 @@ class CreateCommand extends Command {
     const exts = this.collectExternalVersions();
     const localRelative = this.hasLocalRelativeFileSpec();
     const savePrefix = this.conf.get("save-exact") ? "" : this.conf.get("save-prefix");
+    const pacoteOpts = this.conf.snapshot;
 
     const decideVersion = spec => {
       if (this.packageGraph.has(spec.name)) {
@@ -252,7 +253,7 @@ class CreateCommand extends Command {
         }
 
         // from registry
-        return getManifest(spec, this.conf).then(pkg => `${savePrefix}${pkg.version}`);
+        return getManifest(spec, pacoteOpts).then(pkg => `${savePrefix}${pkg.version}`);
       }
 
       if (spec.type === "git") {