fix: update to nx 19 (#4003)

lerna · May 11, 2024 · 03f476b · 03f476b
1 parent c3b9b16
commit 03f476b
Show file tree

Hide file tree

Showing 7 changed files with 3,449 additions and 3,835 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -218,7 +218,7 @@ jobs:
       - name: Check if e2e-run-task-runner is affected
         id: check_affected
         run: |
-          IS_AFFECTED_STR=$(npx nx print-affected | jq '.projects | contains(["e2e-run-task-runner"])')
+          IS_AFFECTED_STR=$(npx nx show projects --json | jq 'any(. | contains("e2e-run-task-runner"))')
           IS_AFFECTED=$([[ $IS_AFFECTED_STR == 'true' ]] && echo 'true' || echo '')
           echo "is_affected=$IS_AFFECTED" >> $GITHUB_OUTPUT
         shell: bash

diff --git a/libs/core/src/lib/pack-directory.ts b/libs/core/src/lib/pack-directory.ts
@@ -2,6 +2,7 @@ import packlist from "npm-packlist";
 import log from "npmlog";
 import path from "path";
 import { IntegrityMap } from "ssri";
+import type { Readable } from "stream";
 import tar from "tar";
 import { getPacked } from "./get-packed";
 import { Package } from "./package";
@@ -44,7 +45,7 @@ export function packDirectory(_pkg: Package | string, dir: string, options: Pack
 
   opts.log.verbose("pack-directory", path.relative(".", pkg.contents));
 
-  let chain = Promise.resolve();
+  let chain = Promise.resolve<void | Readable>(undefined);
 
   if (opts.ignorePrepublish !== true) {
     chain = chain.then(() => runLifecycle(pkg, "prepublish", opts));

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,15 +32,15 @@
   "license": "MIT",
   "homepage": "https://lerna.js.org",
   "devDependencies": {
-    "@nx/esbuild": "18.0.7",
-    "@nx/eslint": "18.0.7",
-    "@nx/eslint-plugin": "18.0.7",
-    "@nx/jest": "18.0.7",
-    "@nx/js": "18.0.7",
-    "@nx/plugin": "18.0.7",
-    "@nx/web": "18.0.7",
+    "@nx/esbuild": "19.0.2",
+    "@nx/eslint": "19.0.2",
+    "@nx/eslint-plugin": "19.0.2",
+    "@nx/jest": "19.0.2",
+    "@nx/js": "19.0.2",
+    "@nx/plugin": "19.0.2",
+    "@nx/web": "19.0.2",
     "@swc-node/register": "1.8.0",
-    "@swc/cli": "0.1.62",
+    "@swc/cli": "0.3.12",
     "@swc/core": "1.3.96",
     "@types/byte-size": "^8.1.0",
     "@types/clone-deep": "^4.0.1",
@@ -74,11 +74,11 @@
     "@types/tmp": "^0.2.3",
     "@types/uuid": "^8.3.4",
     "@types/write-file-atomic": "^4.0.0",
-    "@typescript-eslint/eslint-plugin": "6.20.0",
-    "@typescript-eslint/parser": "6.20.0",
+    "@typescript-eslint/eslint-plugin": "7.8.0",
+    "@typescript-eslint/parser": "7.8.0",
     "env-cmd": "^10.1.0",
     "esbuild": "0.19.5",
-    "eslint": "8.48.0",
+    "eslint": "8.57.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-import": "^2.26.0",
@@ -95,7 +95,7 @@
     "lodash": "^4.17.21",
     "normalize-newline": "^3.0.0",
     "normalize-path": "^3.0.0",
-    "nx": "18.0.7",
+    "nx": "19.0.2",
     "prettier": "^2.2.1",
     "resolve.exports": "2.0.0",
     "tacks": "1.2.6",

diff --git a/packages/legacy-package-management/package.json b/packages/legacy-package-management/package.json
@@ -28,7 +28,7 @@
   "dependencies": {
     "@npmcli/arborist": "7.2.2",
     "@npmcli/run-script": "7.0.2",
-    "@nx/devkit": ">=17.1.2 < 18",
+    "@nx/devkit": ">=17.1.2 < 20",
     "@octokit/rest": "19.0.11",
     "byte-size": "8.1.1",
     "chalk": "4.1.0",

diff --git a/packages/legacy-structure/commands/create/package.json b/packages/legacy-structure/commands/create/package.json
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@npmcli/run-script": "7.0.2",
-    "@nx/devkit": ">=17.1.2 < 19",
+    "@nx/devkit": ">=17.1.2 < 20",
     "@octokit/plugin-enterprise-rest": "6.0.1",
     "@octokit/rest": "19.0.11",
     "byte-size": "8.1.1",
@@ -68,7 +68,7 @@
     "npm-packlist": "5.1.1",
     "npm-registry-fetch": "^14.0.5",
     "npmlog": "^6.0.2",
-    "nx": ">=17.1.2 < 19",
+    "nx": ">=17.1.2 < 20",
     "p-map": "4.0.0",
     "p-map-series": "2.1.0",
     "p-queue": "6.6.2",

diff --git a/packages/lerna/package.json b/packages/lerna/package.json
@@ -39,7 +39,7 @@
   "dependencies": {
     "@lerna/create": "8.1.2",
     "@npmcli/run-script": "7.0.2",
-    "@nx/devkit": ">=17.1.2 < 19",
+    "@nx/devkit": ">=17.1.2 < 20",
     "@octokit/plugin-enterprise-rest": "6.0.1",
     "@octokit/rest": "19.0.11",
     "byte-size": "8.1.1",
@@ -82,7 +82,7 @@
     "npm-packlist": "5.1.1",
     "npm-registry-fetch": "^14.0.5",
     "npmlog": "^6.0.2",
-    "nx": ">=17.1.2 < 19",
+    "nx": ">=17.1.2 < 20",
     "p-map": "4.0.0",
     "p-map-series": "2.1.0",
     "p-pipe": "3.1.0",