Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @jest/transform as an optional peer dependency #4287

Merged
merged 1 commit into from May 19, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Apr 6, 2024

Summary

import type { TransformedSource, Transformer, TransformOptions } from '@jest/transform'

The above import means when using TypeScript there is a dependency on @jest/transform which is currently not expressed, making Yarn Berry unhappy when using the PnP linker.

From what I understand, specifying this dependency as an optional peer dependency should resolve this.

Test plan

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@G-Rath G-Rath requested a review from kulshekhar as a code owner April 6, 2024 22:38
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like similar to the case of @jest/types

@ahnpnl ahnpnl merged commit 0ba7f86 into kulshekhar:main May 19, 2024
11 of 13 checks passed
@G-Rath G-Rath deleted the patch-1 branch May 19, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants