Change the package entry point to preprocessor.js itself #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the `"ts-jest"` package name can be used as Jest transform, instead of specifying the path to preprocessor.js. The latter did not work when the ts-jest package had been hoisted to a parent folder (for example by lerna). Fixes kulshekhar#361
|
@martijnthe Thanks for the PR! I'll review this as soon as I can. In the meanwhile, I have one question - after this is merged, will the current way of specifying the transformer continue to work? It should, to avoid breaking stuff |
@kulshekhar It should yes, I left the existing |
|
I didn't review the code - but loving the idea. |
kulshekhar
previously approved these changes
Nov 7, 2017
|
@kulshekhar thanks, sgtm |
kulshekhar
approved these changes
Nov 8, 2017
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the
"ts-jest"package name can be used as Jest transform, instead of specifying the path to preprocessor.js.The latter did not work when the ts-jest package had been hoisted to a parent folder (for example by lerna).
Fixes #361