Return more information about empty updates (#3597)

lib/query/compiler.js

@@ -18,7 +18,6 @@ const {
   omitBy,
   reduce,
   has,
-  keys,
 } = require('lodash');
 const uuid = require('uuid');
 
@@ -579,9 +578,7 @@ assign(QueryCompiler.prototype, {
   },
 
   distinctOn(value) {
-    throw new Error(
-      '.distinctOn() is currently only supported on PostgreSQL'
-    )
+    throw new Error('.distinctOn() is currently only supported on PostgreSQL');
   },
 
   // On Clause
@@ -786,7 +783,7 @@ assign(QueryCompiler.prototype, {
   _prepUpdate(data = {}) {
     const { counter = {} } = this.single;
 
-    for (const column of keys(counter)) {
+    for (const column of Object.keys(counter)) {
       //Skip?
       if (has(data, column)) {
         //Needed?
@@ -827,6 +824,10 @@ assign(QueryCompiler.prototype, {
           'Empty .update() call detected!',
           'Update data does not contain any values to update.',
           'This will result in a faulty query.',
+          this.single.table ? `Table: ${this.single.table}.` : '',
+          this.single.update
+            ? `Columns: ${Object.keys(this.single.update)}.`
+            : '',
         ].join(' ')
       );
     }

test/unit/query/builder.js

@@ -1,7 +1,7 @@
-/*global expect*/
 /*eslint no-var:0, indent:0, max-len:0 */
 'use strict';
 
+const { expect } = require('chai');
 const MySQL_Client = require('../../../lib/dialects/mysql');
 const PG_Client = require('../../../lib/dialects/postgres');
 const Redshift_Client = require('../../../lib/dialects/redshift');
@@ -9546,12 +9546,12 @@ describe('QueryBuilder', () => {
     try {
       qb()
         .table('sometable')
-        .update({ column: undefined })
+        .update({ foobar: undefined })
         .toString();
       throw new Error('Should not reach this point');
     } catch (error) {
       expect(error.message).to.equal(
-        'Empty .update() call detected! Update data does not contain any values to update. This will result in a faulty query.'
+        'Empty .update() call detected! Update data does not contain any values to update. This will result in a faulty query. Table: sometable. Columns: foobar.'
       );
     }
   });