Skip to content

Commit

Permalink
chore(package): update dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@greenkeeper
greenkeeper[bot] committed Oct 18, 2017
1 parent aee2a48 commit bbd135d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Expand Up @@ -23,8 +23,8 @@
},
"dependencies": {
"accepts": "^1.2.13",
"boom": "^5.0.0",
"hoek": "^4.0.0",
"boom": "^6.0.0",
"hoek": "^5.0.0",
"media-type": "^0.3.0"
},
"devDependencies": {
Expand Down

4 comments on commit bbd135d

@gr2m
Copy link
Collaborator

@gr2m gr2m commented on bbd135d Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like Hoek now requires Node 8 which makes this a breaking change for hapi-json-api. It breaks our tests using v2.0.4 (https://travis-ci.org/hoodiehq/hoodie-account-server/jobs/289904308), tests work again with v2.0.3, see hoodiehq/hoodie-account-server#274

I would suggest you revert this change, release v2.0.5 and then release v3.0.0 and officially drop support for Node < 8 if that’s what you want :)

@gr2m
Copy link
Collaborator

@gr2m gr2m commented on bbd135d Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @kjellmorten

@kjellmorten
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, @gr2m, as I somehow missed your first comment.

And thanks for the suggestion. Your tests should work again with v2.0.5.

@gr2m
Copy link
Collaborator

@gr2m gr2m commented on bbd135d Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

Please sign in to comment.