fix Incorrect childNodes.length after typing in an iframe (close De…

…vExpress#3887) (DevExpress#3888)
kirovboris · Dec 18, 2019 · 896438c · 896438c
1 parent 93f1bf6
commit 896438c
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 9 deletions.
diff --git a/src/client/core/utils/content-editable.js b/src/client/core/utils/content-editable.js
@@ -460,9 +460,8 @@ export function calculateNodeAndOffsetByPosition (el, offset) {
                 point.offset--;
         }
 
-        arrayUtils.forEach(childNodes, node => {
-            point = checkChildNodes(node);
-        });
+        for (let i = 0; i < childNodesLength; i++)
+            point = checkChildNodes(childNodes[i]);
 
         return point;
     }
@@ -505,9 +504,8 @@ export function calculatePositionByNodeAndOffset (el, { node, offset }) {
         else if (!find && (isNodeBlockWithBreakLine(el, target) || isNodeAfterNodeBlockWithBreakLine(el, target)))
             currentOffset++;
 
-        arrayUtils.forEach(childNodes, currentNode => {
-            currentOffset = checkChildNodes(currentNode);
-        });
+        for (let i = 0; i < childNodesLength; i++)
+            currentOffset = checkChildNodes(childNodes[i]);
 
         return currentOffset;
     }
@@ -581,9 +579,8 @@ function getContentEditableNodes (target) {
     if (!isSkippableNode(target) && !childNodesLength && domUtils.isTextNode(target))
         result.push(target);
 
-    arrayUtils.forEach(childNodes, node => {
-        result = result.concat(getContentEditableNodes(node));
-    });
+    for (let i = 0; i < childNodesLength; i++)
+        result = result.concat(getContentEditableNodes(childNodes[i]));
 
     return result;
 }

diff --git a/test/functional/fixtures/regression/gh-3887/pages/index.html b/test/functional/fixtures/regression/gh-3887/pages/index.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta charset="utf-8"/>
+    <title>GH-3887</title>
+    <script>
+        window.onload = function () {
+            var iframe                            = document.querySelector('iframe');
+            iframe.contentDocument.designMode     = 'on';
+            iframe.contentDocument.body.innerHTML = 'a';
+            iframe.contentWindow.focus();
+        };
+    </script>
+</head>
+<body>
+<iframe></iframe>
+</body>
+</html>
diff --git a/test/functional/fixtures/regression/gh-3887/test.js b/test/functional/fixtures/regression/gh-3887/test.js
@@ -0,0 +1,3 @@
+describe('[Regression](GH-3887)', () => {
+    it('Should correctly return childNodes.length after typing in an iframe', () => runTests('testcafe-fixtures/index.js'));
+});
diff --git a/test/functional/fixtures/regression/gh-3887/testcafe-fixtures/index.js b/test/functional/fixtures/regression/gh-3887/testcafe-fixtures/index.js
@@ -0,0 +1,15 @@
+fixture`gh-3887`
+    .page`http://localhost:3000/fixtures/regression/gh-3887/pages/index.html`;
+
+test('Check body.childNodes.length after typing in an iframe', async t => {
+    await t
+        .switchToIframe('iframe')
+        .typeText('body', '=SU', { replace: true })
+        .typeText('body', '=SU', { replace: true })
+        .switchToMainWindow()
+        .pressKey('ctrl');
+
+    const count = await t.eval(() => document.querySelector('iframe').contentDocument.body.childNodes.length);
+
+    await t.expect(count).eql(1);
+});