This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
fix: Normalize command only and not command args(windows) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command arguments can have URLs which should not be normalized. Add optional parameter `commandConvert`(default `false`) and normalize only the command, not the command arguments
index.test.js - should normalize command on windows - should not normalize command arguments on windows command.test.js - normalizes command on windows
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 50 51 +1
=====================================
+ Hits 50 51 +1
Continue to review full report at Codecov.
|
|
Ha ha.. my fault to begin with 😅 |
|
Awesome! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command arguments can have URLs which should not be normalized. This adds optional parameter to function
commandConvert(defaultfalse) and normalizes only the command, and not the command arguments.This also adds tests for cmd normalization on windows
Issue reported by @weizhenye - #130 (comment)
Edit: Turns out there was an issue reported for this as well.
Closes #133