This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
feat(bin): two bins (shell, non-shell) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #104 +/- ##
===================================
Coverage 100% 100%
===================================
Files 3 3
Lines 45 42 -3
===================================
- Hits 45 42 -3
Continue to review full report at Codecov.
|
kentcdodds
suggested changes
Apr 9, 2017
|
I've moved this to go to the |
|
Thanks. I'll get to work on the documentation over the week-end. |
Revert the default bin (cross-env) to its v3 behavior (not using the shell option). Add a new (cross-env-shell) which uses the shell option. BREAKING CHANGE: Scripts using quotes or escape sequences will see a difference in behavior. Switching to the second bin should resolve any issue. Closes kentcdodds#99.
|
Documentation updated. What do you think? |
kentcdodds
approved these changes
Apr 18, 2017
README.md
Outdated
| second one uses the `shell` option from Node's `spawn`. | ||
|
|
||
| The main use case for `cross-env-shell` is when your need an environment | ||
| vartiable to be set across an entire inline shell script, rather than just one |
There was a problem hiding this comment.
vartiable
should be:
variable
| } | ||
| } | ||
| ``` | ||
|
|
||
| The rule of thumb is: if you want to pass to `cross-env` a command that |
|
I fixed the typo. I'll release a beta for the |
kentcdodds
pushed a commit
that referenced
this pull request
May 11, 2017
Revert the default bin (cross-env) to its v3 behavior (not using the shell option). Add a new (cross-env-shell) which uses the shell option. BREAKING CHANGE: Scripts using quotes or escape sequences will see a difference in behavior. Switching to the second bin should resolve any issue. Closes #99.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the default bin (cross-env) to its v3 behavior (not using the shell option). Add a new
(cross-env-shell) which uses the shell option.
BREAKING CHANGE: Scripts using quotes or escape sequences will see a difference in behavior.
Switching to the second bin should resolve any issue.
Closes #99.
See prior discussion in #99 et and #102.