Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(proxy): Allow to configure changeOrigin option of http-proxy #1743

Merged

Conversation

Volune
Copy link
Contributor

@Volune Volune commented Dec 2, 2015

As discussed in #1729

Motivation: allow development of extended configuration per proxy
Example:
  proxies: {
    '/foo': 'http://foo.localhost',
    '/bar': {target: 'http://bar.localhost'}
  }
http-proxy has an option 'changeOrigin' (disabled by default) to rewrite
 the Host header in proxified requests wih the host from the target
 configuration.

Closes karma-runner#1729
@dignifiedquire
Copy link
Member

Thanks, can you please add documentation for this feature as well?

@Volune
Copy link
Contributor Author

Volune commented Dec 3, 2015

Added some documentation. I'm far from experienced at documenting, so let me know if that needs improvements.

@dignifiedquire
Copy link
Member

Looks good, thanks :octocat:

dignifiedquire added a commit that referenced this pull request Dec 3, 2015
Feature(proxy): Allow to configure changeOrigin option of http-proxy
@dignifiedquire dignifiedquire merged commit e8fdf38 into karma-runner:master Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants