fix(file-list): refresh resolves before 'file_list_modified' event #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._emitModified = function (immediate) { | ||
| immediate ? emit() : throttledEmit() | ||
| } | ||
| }()) |
There was a problem hiding this comment.
No need to hide these so much, you can just put the outside the constructor like this
function emit (self) {...}
function throttledEmit(self) {...}
...
self._emitModified = function (immediate) {
immediate ? emit(self) : throttledEmit(self)
}
|
Thanks I left some inline comments |
|
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
thetrevdev
force-pushed
the
fix-file-list-refresh-resolves-before-modified-event
branch
2 times, most recently
from
0be73c0
to
ce08f06
Compare
|
Updated. |
|
Thanks could you rebase onto the latest master please? |
thetrevdev
force-pushed
the
fix-file-list-refresh-resolves-before-modified-event
branch
from
ce08f06
to
fe195d7
Compare
|
done |
|
Thanks |
|
Damn can't merge anymore cause I merged the other one first. |
change emitModified to emit 'file_list_modified' immediately during refresh() to remove throttle and race condition during subsequent runner executions Closes karma-runner#1550
thetrevdev
force-pushed
the
fix-file-list-refresh-resolves-before-modified-event
branch
from
fe195d7
to
65f1eca
Compare
|
Rebased |
dignifiedquire
added a commit
that referenced
this pull request
Aug 10, 2015
…es-before-modified-event fix(file-list): refresh resolves before 'file_list_modified' event
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-list - file_list_modified should be emitted before refresh promise resolves
Runner test execution is scheduled after file-list refresh resolves. The web-server gets the file-list from the last file_list_modified event. This was resulting in a race condition where the web server would grab a stale file list.
Closes #1550