Safeguard IE against console.log #1318
Conversation
|
@freethejazz Thanks. Change commit message following commit message convention |
Shield a reference to `window.console.log` with a simple if statement. Fix the ability to use this page in IE without the inspector open. This was particularly an issue for developers running karma from within a Microsoft-based IDE. The log message will just be swallowed on environments that don't support `window.console`. Closes karma-runner#1209
|
Sorry about that @maksimr. That commit message is fixed and I've just signed the CLA. Do you want me to close this PR and resubmit one with an appropriately named branch? |
No, change commit message is enough. Thanks! |
|
Hmm, looks the build failed when run on node 0.8 but passed for 0.10. Do you see that often? |
|
@freethejazz I didn't see it before, seems it's random error(which should be fixed). |
|
Looks like you were right, thanks for restarting. |
|
#merge |
|
@maksimr I'm totally new to this process, but shouldn't the karmarunnerbot have picked up on this by now? |
|
@freethejazz yup |
Safeguard IE against console.log
Shielding a reference to
window.console.log. Fixes the ability to use this page in IE without the inspector open. Fixes #1209.