feat(preprocessor): Allow preprocessor to handle binary files #3054
Conversation
| @@ -125,7 +120,12 @@ function createPreprocessor (config, basePath, injector) { | |||
| } | |||
|
|
|||
| instances[name] = p | |||
| preprocessors.push(p) | |||
| if (!thisFileIsBinary || p.handleBinaryFiles) { | |||
There was a problem hiding this comment.
Do we really need handleBinaryFiles flag and this whole if statement ? Maybe we can just allow to preprocess binary files, and if something fails, preprocessor will throw error.
I guess in more than 90% there will be no binary files that matches pattern and should be preprocessed (Do I miss something ?).
Just thinking out loud, and I'm curious others opinion about that.
There was a problem hiding this comment.
This is just for safe backwards compatibility.
Currently if there is a pattern foo/* that matches binary files, it is ignored. Without this flag, the 10% projects that do include binary files in their pattern will break.
lib/preprocessor.js
Outdated
| if (!thisFileIsBinary || p.handleBinaryFiles) { | ||
| preprocessors.push(p) | ||
| } else { | ||
| log.warn('Ignoring preprocessing (%s) %s because it is a binary file.', |
There was a problem hiding this comment.
I think this message could be clearer as
'Ignoring preprocessing %s because %s has handleBinaryFiles false.'
Karma currently detects whether a file is binary, and does not allow binary files to be passed on to preprocessors. This PR removes this restriction, and allows binary files to be handled by preprocessors.
See #3046