feat(preprocessor): Allow preprocessor to handle binary files

karma-runner · Jun 15, 2018 · a1478bd · a1478bd
1 parent 05dd09a
commit a1478bd
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/lib/preprocessor.js b/lib/preprocessor.js
@@ -98,12 +98,7 @@ function createPreprocessor (config, basePath, injector) {
         var preprocessorNames = []
         for (var i = 0; i < patterns.length; i++) {
           if (mm(file.originalPath, patterns[i], {dot: true})) {
-            if (thisFileIsBinary) {
-              log.warn('Ignoring preprocessing (%s) %s because it is a binary file.',
-                config[patterns[i]].join(', '), file.originalPath)
-            } else {
-              preprocessorNames = combineLists(preprocessorNames, config[patterns[i]])
-            }
+            preprocessorNames = combineLists(preprocessorNames, config[patterns[i]])
           }
         }
 
@@ -125,7 +120,12 @@ function createPreprocessor (config, basePath, injector) {
           }
 
           instances[name] = p
-          preprocessors.push(p)
+          if (!thisFileIsBinary || p.handleBinaryFiles) {
+            preprocessors.push(p)
+          } else {
+            log.warn('Ignoring preprocessing (%s) %s because it is a binary file.',
+              name, file.originalPath)
+          }
         })
 
         nextPreprocessor(null, thisFileIsBinary ? buffer : buffer.toString())