refactor(server): Clearer error messages on fatal errors

karma-runner · Oct 13, 2018 · f28a454 · f28a454
1 parent 4651524
commit f28a454
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/server.js b/lib/server.js
@@ -57,7 +57,7 @@ class Server extends KarmaEventEmitter {
     super()
     logger.setupFromConfig(cliOptions)
 
-    this.log = logger.create()
+    this.log = logger.create('karma-server')
 
     this.loadErrors = []
 
@@ -124,7 +124,9 @@ class Server extends KarmaEventEmitter {
         this._boundServer = boundServer
         this._injector.invoke(this._start, this)
       })
-      .catch(this.dieOnError.bind(this))
+      .catch((err) => {
+        this.dieOnError(`Server start failed on port ${config.port}: ${err}`)
+      })
   }
 
   get (token) {
@@ -156,7 +158,9 @@ class Server extends KarmaEventEmitter {
     const singleRunBrowsers = new BrowserCollection(new EventEmitter())
     let singleRunBrowserNotCaptured = false
 
-    webServer.on('error', this.dieOnError.bind(this))
+    webServer.on('error', (err) => {
+      this.dieOnError(`Webserver fail ${err}`)
+    })
 
     const afterPreprocess = () => {
       if (config.autoWatch) {

diff --git a/lib/utils/net-utils.js b/lib/utils/net-utils.js
@@ -14,7 +14,7 @@ const NetUtils = {
           if (err.code === 'EADDRINUSE' || err.code === 'EACCES') {
             server.listen(++port, listenAddress)
           } else {
-            reject(err)
+            reject(new Error(`Failed to bind ${port}: ` + (err.stack || err)))
           }
         })
         .on('listening', () => {