Skip to content

Commit

Permalink
docs: simplify repository setup steps (#3478)
Browse files Browse the repository at this point in the history
Use `npm` scripts instead of shell commands and Grunt.
  • Loading branch information
devoto13 committed Apr 20, 2020
1 parent 652e24e commit b52333d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
13 changes: 7 additions & 6 deletions docs/dev/02-making-changes.md
Expand Up @@ -23,11 +23,12 @@ Here are some tips on how to set up a Karma workspace and how to send a good pul
* Install for development. Use a recent npm version, ignore peerdep warnings
```bash
$ npm install
$ rm -rf node_modules/karma
$ cd node_modules
$ ln -s ../ karma
$ cd ../
$ grunt browserify

$ npm run init
# or if you're on Windows
$ npm run init:windows

$ npm run build
```

## Testing and Building
Expand All @@ -49,7 +50,7 @@ Here are some tips on how to set up a Karma workspace and how to send a good pul

- Build the client code via:
```bash
$ npm build
$ npm run build
```

## Changing the Code
Expand Down
11 changes: 6 additions & 5 deletions test/client/karma.conf.js
Expand Up @@ -57,11 +57,12 @@ fs.lstat('node_modules/karma', (err, stats) => {
console.log('**** Incorrect directory layout for karma self-tests ****')
console.log(`
$ npm install
$ rm -rf node_modules/karma
$ cd node_modules
$ ln -s ../ karma
$ cd ../
$ grunt browserify
$ npm run init
# or if you're on Windows
$ npm run init:windows
$ npm run build
`)
process.exit(1)
})
Expand Down

0 comments on commit b52333d

Please sign in to comment.