Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Commit

Permalink
Merge pull request #158 from csvn/fix-configuration-options
Browse files Browse the repository at this point in the history
fix: make configuration options work again
  • Loading branch information
kalamcs committed Mar 16, 2020
2 parents 76dbfd0 + b83641a commit 5ec5e03
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -58,7 +58,7 @@ module.exports = function(config) {
- `username` your BS username, you can also use `BROWSERSTACK_USERNAME` env variable.
- `accessKey` your BS access key, you can also use `BROWSERSTACK_ACCESS_KEY` env variable.
- `startTunnel` do you wanna establish the BrowserStack tunnel ? (defaults to `true`)
- `tunnelIdentifier` in case you want to start the BrowserStack tunnel outside `karma` by setting `startTunnel` to `false`, set the identifier passed to the `-localIdentifier` option here (optional)
- `tunnelIdentifier`/`localIdentifier` in case you want to start the BrowserStack tunnel outside `karma` by setting `startTunnel` to `false`, set the identifier passed to the `-localIdentifier` option here (optional)
- `retryLimit` how many times do you want to retry to capture the browser ? (defaults to `3`)
- `captureTimeout` the browser capture timeout (defaults to `120`)
- `timeout` the BS worker timeout (defaults to `300`
Expand Down
6 changes: 5 additions & 1 deletion index.js
Expand Up @@ -13,7 +13,11 @@ var createBrowserStackTunnel = function (logger, config, emitter) {

const bsAccesskey = process.env.BROWSERSTACK_ACCESS_KEY || process.env.BROWSER_STACK_ACCESS_KEY || bsConfig.accessKey
const bsLocal = new browserstack.Local()
const bsLocalArgs = { key: bsAccesskey }
const bsLocalArgs = {
key: bsAccesskey,
localIdentifier: bsConfig.localIdentifier || bsConfig.tunnelIdentifier || undefined,
forceLocal: bsConfig.forceLocal || undefined
}
const deferred = Q.defer()

log.debug('Starting BrowserStackLocal')
Expand Down

0 comments on commit 5ec5e03

Please sign in to comment.