fix pipe(streams, fn) api. closes #51

juliangruber · Jan 20, 2019 · bfa1972 · bfa1972
1 parent ba798ce
commit bfa1972
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -27,18 +27,19 @@ const defaultOpts = {
 const pipe = (...streams) => {
   let opts, cb
 
-  if (Array.isArray(streams[0])) {
-    streams = streams[0]
-  }
   if (typeof streams[streams.length - 1] === 'function') {
     cb = streams.pop()
   }
   if (
     typeof streams[streams.length - 1] === 'object' &&
+    !Array.isArray(streams[streams.length - 1]) &&
     typeof streams[streams.length - 1].pipe !== 'function'
   ) {
     opts = streams.pop()
   }
+  if (Array.isArray(streams[0])) {
+    streams = streams[0]
+  }
 
   const first = streams[0]
   const last = streams[streams.length - 1]

diff --git a/test/multipipe.js b/test/multipipe.js
@@ -212,3 +212,20 @@ describe('pipe(a, b, c, fn)', () => {
     c.emit('finish', true)
   })
 })
+
+describe('pipe([a, b, c], fn)', () => {
+  it('should call on finish', done => {
+    let finished = false
+    const a = Readable()
+    const b = Transform()
+    const c = Writable(function () {
+      finished = true
+    })
+
+    pipe([a, b, c], err => {
+      assert(!err)
+      assert(finished)
+      done()
+    })
+  })
+})