Add JSDoc type annotations

lib/rules/boolean-prop-naming.js

@@ -22,6 +22,8 @@ const messages = {
   patternMismatch: 'Prop name `{{propName}}` doesn’t match rule `{{pattern}}`',
 };
 
+
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/button-has-type.js

@@ -28,6 +28,7 @@ const messages = {
   forbiddenValue: '"{{value}}" is an invalid value for button type attribute',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -149,9 +150,11 @@ module.exports = {
         }
 
         const props = node.arguments[1].properties;
-        const typeProp = props.find((prop) => prop.key && prop.key.name === 'type');
+        const typeProp = props.find(
+          (prop) => prop.type === "Property" && prop.key && prop.key.type === "PrivateIdentifier" && prop.key.name === 'type'
+        );
 
-        if (!typeProp) {
+        if (typeProp.type !== "Property") {
           reportMissing(node);
           return;
         }

lib/rules/checked-requires-onchange-or-readonly.js

@@ -24,7 +24,7 @@ const defaultOptions = {
 };
 
 /**
- * @param {string[]} properties
+ * @param {Array} properties
  * @param {string} keyName
  * @returns {Set<string>}
  */
@@ -41,6 +41,7 @@ function extractTargetProps(properties, keyName) {
   );
 }
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/default-props-match-prop-types.js

@@ -21,6 +21,7 @@ const messages = {
   defaultHasNoType: 'defaultProp "{{name}}" has no corresponding propTypes declaration.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/destructuring-assignment.js

@@ -53,6 +53,7 @@ const messages = {
   destructureInSignature: 'Must destructure props in the function signature.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/display-name.js

@@ -27,6 +27,7 @@ const messages = {
   noContextDisplayName: 'Context definition is missing display name',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/forbid-component-props.js

@@ -22,6 +22,7 @@ const messages = {
   propIsForbidden: 'Prop "{{prop}}" is forbidden on Components',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/forbid-dom-props.js

@@ -37,6 +37,7 @@ const messages = {
   propIsForbidden: 'Prop "{{prop}}" is forbidden on DOM Nodes',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/forbid-elements.js

@@ -19,6 +19,7 @@ const messages = {
   forbiddenElement_message: '<{{element}}> is forbidden, {{message}}',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -103,13 +104,11 @@ module.exports = {
           return;
         }
 
-        const argType = argument.type;
-
-        if (argType === 'Identifier' && /^[A-Z_]/.test(argument.name)) {
+        if (argument.type === 'Identifier' && /^[A-Z_]/.test(argument.name)) {
           reportIfForbidden(argument.name, argument);
-        } else if (argType === 'Literal' && /^[a-z][^.]*$/.test(argument.value)) {
+        } else if (argument.type === 'Literal' && /^[a-z][^.]*$/.test(argument.value.toString())) {
           reportIfForbidden(argument.value, argument);
-        } else if (argType === 'MemberExpression') {
+        } else if (argument.type === 'MemberExpression') {
           reportIfForbidden(context.getSourceCode().getText(argument), argument);
         }
       },

lib/rules/forbid-foreign-prop-types.js

@@ -13,6 +13,7 @@ const messages = {
   forbiddenPropType: 'Using propTypes from another component is not safe because they may be removed in production builds',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -108,7 +109,7 @@ module.exports = {
             && !ast.isAssignmentLHS(node)
             && !isAllowedAssignment(node)
           )) || (
-            (node.property.type === 'Literal' || node.property.type === 'JSXText')
+            node.property.type === 'Literal'
             && node.property.value === 'propTypes'
             && !ast.isAssignmentLHS(node)
             && !isAllowedAssignment(node)
@@ -121,7 +122,9 @@ module.exports = {
       },
 
       ObjectPattern(node) {
-        const propTypesNode = node.properties.find((property) => property.type === 'Property' && property.key.name === 'propTypes');
+        const propTypesNode = node.properties.find(
+          (property) => property.type === 'Property' && property.key.type === "PrivateIdentifier" && property.key.name === 'propTypes'
+        );
 
         if (propTypesNode) {
           report(context, messages.forbiddenPropType, 'forbiddenPropType', {

lib/rules/forbid-prop-types.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /**
  * @fileoverview Forbid certain propTypes
  */
@@ -25,6 +26,7 @@ const messages = {
   forbiddenPropType: 'Prop type "{{target}}" is forbidden',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/function-component-definition.js

@@ -113,6 +113,7 @@ const messages = {
   'arrow-function': 'Function component is not an arrow function',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/hook-use-state.js

@@ -25,6 +25,7 @@ const messages = {
   suggestMemo: 'Replace useState call with useMemo',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/iframe-missing-sandbox.js

@@ -109,6 +109,7 @@ function checkProps(context, node) {
   }
 }
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-boolean-value.js

@@ -54,6 +54,7 @@ const messages = {
   omitPropAndBoolean: 'Value must be omitted for `false` attribute: `{{propName}}`',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-child-element-spacing.js

@@ -44,6 +44,7 @@ const messages = {
   spacingBeforeNext: 'Ambiguous spacing before next element {{element}}',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-closing-bracket-location.js

@@ -17,6 +17,7 @@ const messages = {
   bracketLocation: 'The closing bracket must be {{location}}{{details}}',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -195,7 +196,9 @@ module.exports = {
      */
     function getTokensLocations(node) {
       const sourceCode = context.getSourceCode();
+      // @ts-ignore
       const opening = sourceCode.getFirstToken(node).loc.start;
+      // @ts-ignore
       const closing = sourceCode.getLastTokens(node, node.selfClosing ? 2 : 1)[0].loc.start;
       const tag = sourceCode.getFirstToken(node.name).loc.start;
       let lastProp;

lib/rules/jsx-closing-tag-location.js

@@ -18,6 +18,7 @@ const messages = {
   matchIndent: 'Expected closing tag to match indentation of opening.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-curly-brace-presence.js

@@ -36,6 +36,7 @@ const messages = {
   missingCurly: 'Need to wrap this literal in a JSX expression.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-curly-newline.js

@@ -41,6 +41,7 @@ const messages = {
   unexpectedAfter: 'Unexpected newline after \'{\'.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     type: 'layout',

lib/rules/jsx-curly-spacing.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /**
  * @fileoverview Enforce or disallow spaces inside of curly braces in JSX attributes.
  * @author Jamund Ferguson
@@ -34,6 +35,7 @@ const messages = {
   spaceNeededBefore: 'A space is required before \'{{token}}\'',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-equals-spacing.js

@@ -19,6 +19,7 @@ const messages = {
   needSpaceAfter: 'A space is required after \'=\'',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -61,7 +62,9 @@ module.exports = {
 
           const sourceCode = context.getSourceCode();
           const equalToken = sourceCode.getTokenAfter(attrNode.name);
+          // @ts-ignore
           const spacedBefore = sourceCode.isSpaceBetweenTokens(attrNode.name, equalToken);
+          // @ts-ignore
           const spacedAfter = sourceCode.isSpaceBetweenTokens(equalToken, attrNode.value);
 
           if (config === 'never') {

lib/rules/jsx-filename-extension.js

@@ -28,6 +28,7 @@ const messages = {
   extensionOnlyForJSX: 'Only files containing JSX may use the extension \'{{ext}}\'',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-first-prop-new-line.js

@@ -17,6 +17,7 @@ const messages = {
   propOnSameLine: 'Property should be placed on the same line as the component declaration',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-fragments.js

@@ -27,6 +27,7 @@ const messages = {
   preferFragment: 'Prefer fragment shorthand over {{react}}.{{fragment}}',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -171,7 +172,7 @@ module.exports = {
       ImportDeclaration(node) {
         if (node.source && node.source.value === 'react') {
           node.specifiers.forEach((spec) => {
-            if (spec.imported && spec.imported.name === fragmentPragma) {
+            if (spec.type === "ImportSpecifier" && spec.imported && spec.imported.name === fragmentPragma) {
               if (spec.local) {
                 fragmentNames.add(spec.local.name);
               }

lib/rules/jsx-handler-names.js

@@ -17,6 +17,7 @@ const messages = {
   badPropKey: 'Prop key for {{propValue}} must begin with \'{{handlerPropPrefix}}\'',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-indent-props.js

@@ -42,6 +42,7 @@ const messages = {
   wrongIndent: 'Expected indentation of {{needed}} {{type}} {{characters}} but found {{gotten}}.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -140,6 +141,7 @@ module.exports = {
      * @return {Number} Indent
      */
     function getNodeIndent(node) {
+      // @ts-ignore
       let src = context.getSourceCode().getText(node, node.loc.start.column + extraColumnStart);
       const lines = src.split('\n');
       src = lines[0];

lib/rules/jsx-indent.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /**
  * @fileoverview Validate JSX indentation
  * @author Yannick Croissant
@@ -45,6 +46,7 @@ const messages = {
   wrongIndent: 'Expected indentation of {{needed}} {{type}} {{characters}} but found {{gotten}}.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-key.js

@@ -32,6 +32,7 @@ const messages = {
   nonUniqueKeys: '`key` prop must be unique',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-max-depth.js

@@ -20,6 +20,7 @@ const messages = {
   wrongDepth: 'Expected the depth of nested jsx elements to be <= {{needed}}, but found {{found}}.',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-max-props-per-line.js

@@ -23,6 +23,7 @@ const messages = {
   newLine: 'Prop `{{prop}}` must be placed on a new line',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-newline.js

@@ -23,6 +23,7 @@ function isMultilined(node) {
   return node && node.loc.start.line !== node.loc.end.line;
 }
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {

lib/rules/jsx-no-bind.js

@@ -23,6 +23,7 @@ const messages = {
   func: 'JSX props should not use functions',
 };
 
+/** @type { import('eslint').Rule.RuleModule } */
 module.exports = {
   meta: {
     docs: {
@@ -123,7 +124,7 @@ module.exports = {
     }
 
     function getBlockStatementAncestors(node) {
-      return context.getAncestors(node).filter(
+      return context.getAncestors().filter(
         (ancestor) => ancestor.type === 'BlockStatement'
       ).reverse();
     }
@@ -174,7 +175,9 @@ module.exports = {
         if (
           blockAncestors.length > 0
           && variableViolationType
+          && node.parent.type === "VariableDeclaration"
           && node.parent.kind === 'const' // only support const right now
+          && node.id.type === 'Identifier'
         ) {
           addVariableNameToSet(
             variableViolationType, node.id.name, blockAncestors[0].range[0]