Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: jsx-one-expression-per-line #1497

Merged
merged 14 commits into from
Oct 30, 2017
Merged

New rule: jsx-one-expression-per-line #1497

merged 14 commits into from
Oct 30, 2017

Commits on Oct 25, 2017

  1. new rule: one-element-per-line

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    618bdb7 View commit details
    Browse the repository at this point in the history

  2. require jsx-one-element-per-line in index.js

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    7f6784e View commit details
    Browse the repository at this point in the history

  3. fix sibling reporting

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    256e5bc View commit details
    Browse the repository at this point in the history

  4. short-circuit childrenOnLine finder when a child is found

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    3893c3d View commit details
    Browse the repository at this point in the history

  5. refactor rule to simply check parent line instead of all children

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    652683d View commit details
    Browse the repository at this point in the history

  6. credit where credit is due

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    a45e9c4 View commit details
    Browse the repository at this point in the history

  7. fix always reporting new line required for all siblings

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    8e81d90 View commit details
    Browse the repository at this point in the history

  8. add an invalid test case using html tags

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    e51c4cf View commit details
    Browse the repository at this point in the history

  9. failing tests describing how to handle non-element jsx nodes

    @TSMMark
    TSMMark committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    799dfa6 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2017

  1. rework internals to check children of JSXElement

    @TSMMark
    TSMMark committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    7bdc856 View commit details
    Browse the repository at this point in the history

  2. handle certain cases in one pass

    @TSMMark
    TSMMark committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    cb5f447 View commit details
    Browse the repository at this point in the history

  3. rename to jsx-one-expression-per-line 

    Now that we handle all nodes instead of only React elements, this name
seems more fitting.
    @TSMMark
    TSMMark committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    a18c30b View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2017

  1. strip spaces but leave line returns

    @TSMMark
    TSMMark committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    1344f1d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. use better practices 

    thanks @lencioni
    @TSMMark
    TSMMark committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    cd3648c View commit details
    Browse the repository at this point in the history