WIP: Add option style to jsx-wrap-multilines rule #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jan 23, 2017
| @@ -1,11 +1,24 @@ | |||
| # Prevent missing parentheses around multiline JSX (jsx-wrap-multilines) | |||
|
|
|||
| Wrapping multiline JSX in parentheses can improve readability and/or convenience. It optionally takes a second parameter in the form of an object, containing places to apply the rule. By default, `"declaration"`, `"assignment"`, and `"return"` syntax is checked, but these can be explicitly disabled. Any syntax type missing in the object will follow the default behavior (become enabled). | |||
| Wrapping multiline JSX in parentheses can improve readability and/or convenience*. It optionally takes a second parameter in the form of an object, containing places to apply the rule. By default, `"declaration"`, `"assignment"`, and `"return"` syntax is checked, but these can be explicitly disabled. Any syntax type missing in the object will follow the default behavior (become enabled). | |||
There was a problem hiding this comment.
Using a * here won't translate to a footnote below - I think perhaps leaving this paragraph alone, and adding a second paragraph that describes "never", would be better.
| "return": bool, // default true | ||
| }] | ||
| ``` | ||
|
|
||
| The following patterns are considered warnings: |
There was a problem hiding this comment.
we'll need to add "considered warnings" and "not considered warnings" examples for the "never" option as well.
|
|
||
| ```js | ||
| "react/jsx-wrap-multilines": ["error", { | ||
| "style": "always|never", // default "always" |
There was a problem hiding this comment.
I don't think adding an object property is the best schema here - I think we want to be able to do:
["error", "never", {
…
}]
["error", "always", {
…
}]
["error", { // implies "always"
…
}]
There was a problem hiding this comment.
Yeah.. agree, I'll try to do it tomorrow, with the docs stuff.
ghost
changed the title
|
Superseded by #1475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option style can be either "always" or "never". Default is "always", means wrap jsx in parentheses. Never disallows parentheses around jsx.