refactor: removed a unnecessary if/else

jsx-eslint · Nov 20, 2022 · e685c66 · e685c66
1 parent f017a31
commit e685c66
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/lib/rules/ensure-matching-remove-event-listener.js b/lib/rules/ensure-matching-remove-event-listener.js
@@ -95,19 +95,10 @@ module.exports = {
         }
         if (hasAddEventListener) {
           if (!hasRemoveEventListener) {
-            if (!hasReturnStatement) {
-              const messageId = 'requiredCleanup';
-
-              report(context, messages, messageId, {
-                node,
-              });
-            } else {
-              const messageId = 'requiredRemoveEventListener';
-
-              report(context, messages, messageId, {
-                node,
-              });
-            }
+            const messageID = hasReturnStatement ? 'requiredRemoveEventListener' : 'requiredCleanup';
+            report(context, messages[messageID], messageID, {
+              node,
+            });
           }
         }
       }