Skip to content

Commit

Permalink
[[CHORE]] Relocate development dependency
Browse files Browse the repository at this point in the history
The `unicode-5.2.0` npm module is not necessary when running JSHint; it
is included in this project only during development for the purposes of
generating static data. Relocate the reference to the package in the
project's manifest so that it is not needlessly downloaded by consumers
during typical package installation. Simplify the related logic which
dynamically loaded the latest unicode module to instead load via a
static string value.
  • Loading branch information
jugglinmike authored and rwaldron committed Aug 6, 2018
1 parent f70250b commit 80c7fda
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -46,8 +46,7 @@
"lodash": "~4.17.10",
"minimatch": "~3.0.2",
"shelljs": "0.3.x",
"strip-json-comments": "1.0.x",
"unicode-5.2.0": "^0.7.5"
"strip-json-comments": "1.0.x"
},
"devDependencies": {
"async": "~2.1.2",
Expand All @@ -65,6 +64,7 @@
"results-interpreter": "~1.0.0",
"sinon": "1.12.x",
"test262-stream": "~1.1.0",
"unicode-5.2.0": "^0.7.5",
"unicode-11.0.0": "0.7.x"
},
"license": "(MIT AND JSON)",
Expand Down
5 changes: 1 addition & 4 deletions scripts/generate-identifier-data.js
Expand Up @@ -4,10 +4,7 @@

var regenerate = require('regenerate');

// Which Unicode version should be used?
var pkg = require('../package.json');
var dependencies = Object.keys(pkg.devDependencies);
var unicodeVersion = dependencies.find((name) => /^unicode-\d/.test(name));
var unicodeVersion = 'unicode-11.0.0';
var oldUnicodeVersion = 'unicode-5.2.0';

// Shorthand functions.
Expand Down

0 comments on commit 80c7fda

Please sign in to comment.