Enable Blob-slice.html test in Node.js v10

The issue with `instanceof ArrayBuffer` was fixed in Node.js v10.4.0. See: nodejs/node#20978
jsdom · Jun 18, 2018 · d6f8a97 · d6f8a97
1 parent 3afbc0f
commit d6f8a97
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/test/web-platform-tests/run-wpts.js b/test/web-platform-tests/run-wpts.js
@@ -15,7 +15,6 @@ const validReasons = new Set([
   "needs-await",
   "needs-node8",
   "needs-node10",
-  "fails-node10",
   "timeout-node6" // For tests that timeout in Node.js v6, but pass in later versions
 ]);
 
@@ -28,7 +27,6 @@ try {
 
 const hasNode8 = Number(process.versions.node.split(".")[0]) >= 8;
 const hasNode10 = Number(process.versions.node.split(".")[0]) >= 10;
-const isNode10 = Number(process.versions.node.split(".")[0]) === 10;
 
 const manifestFilename = path.resolve(__dirname, "wpt-manifest.json");
 const manifest = readManifest(manifestFilename);
@@ -67,8 +65,7 @@ describe("web-platform-tests", () => {
           const expectFail = (reason === "fail") ||
                              (reason === "needs-await" && !supportsAwait) ||
                              (reason === "needs-node8" && !hasNode8) ||
-                             (reason === "needs-node10" && !hasNode10) ||
-                             (reason === "fails-node10" && isNode10);
+                             (reason === "needs-node10" && !hasNode10);
 
           if (matchingPattern && shouldSkip) {
             specify.skip(`[${reason}] ${testFile}`);

diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml
@@ -9,7 +9,6 @@ blob/Blob-constructor.html: [fail, "- Blob is not a function
                                     - HTMLSelectElement does not have indexed properties
                                     - MessageChannel not implemented
                                     - element attributes does not have indexed properties"]
-blob/Blob-slice.html: [fails-node10, instanceof ArrayBuffer is failing, https://github.com/nodejs/node/issues/20978]
 file/File-constructor-endings.html: [needs-await]
 file/send-file-form*: [fail, DataTransfer not implemented]
 filelist-section/filelist.html: [fail, function is not instanceof Function]