Skip to content

Commit

Permalink
Remove 'needs-await' reason
Browse files Browse the repository at this point in the history
All supported versions of Node.js include `await` now.
  • Loading branch information
Zirro authored and domenic committed Aug 19, 2018
1 parent 553b05f commit b0d40f7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
9 changes: 0 additions & 9 deletions test/web-platform-tests/run-wpts.js
Expand Up @@ -12,17 +12,9 @@ const validReasons = new Set([
"timeout",
"flaky",
"mutates-globals",
"needs-await",
"needs-node10"
]);

let supportsAwait = true;
try {
eval("async () => { await 0; }"); // eslint-disable-line no-eval
} catch (e) {
supportsAwait = false;
}

const hasNode10 = Number(process.versions.node.split(".")[0]) >= 10;

const manifestFilename = path.resolve(__dirname, "wpt-manifest.json");
Expand Down Expand Up @@ -59,7 +51,6 @@ describe("web-platform-tests", () => {
const reason = matchingPattern && toRunDoc[matchingPattern][0];
const shouldSkip = ["timeout", "flaky", "mutates-globals"].includes(reason);
const expectFail = (reason === "fail") ||
(reason === "needs-await" && !supportsAwait) ||
(reason === "needs-node10" && !hasNode10);

if (matchingPattern && shouldSkip) {
Expand Down
5 changes: 0 additions & 5 deletions test/web-platform-tests/to-run.yaml
@@ -1,21 +1,18 @@
DIR: FileAPI

FileReader/workers.html: [fail, Needs Worker implementation]
blob/Blob-constructor-endings.html: [needs-await]
blob/Blob-constructor.html: [fail, "- Blob is not a function
- a date is not instanceof Date
- a regexp is not instanceof Regexp
- strange v8 behaviour when error triggered in overridden array length
- HTMLSelectElement does not have indexed properties
- MessageChannel not implemented
- element attributes does not have indexed properties"]
file/File-constructor-endings.html: [needs-await]
file/send-file-form*: [fail, DataTransfer not implemented]
filelist-section/filelist.html: [fail, function is not instanceof Function]
historical.https.html: [fail, Needs Service Worker implementation]
idlharness.html: [fail, URL.createObjectURL not implemented]
reading-data-section/**: [timeout, Unknown]
unicode.html: [needs-await]
url/**: [timeout, blob URLs not implemented]

---
Expand Down Expand Up @@ -263,10 +260,8 @@ source/navigate-child-function.html: [timeout, Unknown]
DIR: html/browsers/browsing-the-web/scroll-to-fragid

003.html: [fail, We don't update scrollTop because we don't calculate layout]
forward-triggers-hashchange.html: [needs-await]
fragment-and-encoding-2.html: [fail, Unknown]
fragment-and-encoding.html: [fail, Unknown]
replacement-enabled.html: [needs-await]
scroll-frag-percent-encoded.html: [fail, We don't update scrollTop because we don't calculate layout]
scroll-position-vertical-lr.html: [fail, We don't update scrollX because we don't calculate layout]
scroll-position-vertical-rl.html: [fail, We don't update scrollX because we don't calculate layout]
Expand Down

0 comments on commit b0d40f7

Please sign in to comment.