Skip to content

Commit

Permalink
Remove mutates-globals test reason (#2807)
Browse files Browse the repository at this point in the history
The mutates-global failure reason is not needed anymore after the release of the constructor and prototype reform.
  • Loading branch information
pmdartus authored and TimothyGu committed Jan 24, 2020
1 parent afc85c8 commit 6928d6d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions test/web-platform-tests/run-wpts.js
Expand Up @@ -14,7 +14,6 @@ const validReasons = new Set([
"fail-with-canvas",
"timeout",
"flaky",
"mutates-globals",
"needs-node10",
"needs-node11",
"needs-node12",
Expand Down Expand Up @@ -59,7 +58,7 @@ describe("web-platform-tests", () => {

const testFile = testFilePath.slice((toRunDoc.DIR + "/").length);
const reason = matchingPattern && toRunDoc[matchingPattern][0];
const shouldSkip = ["fail-slow", "timeout", "flaky", "mutates-globals"].includes(reason) ||
const shouldSkip = ["fail-slow", "timeout", "flaky"].includes(reason) ||
(["fail-with-canvas", "needs-canvas"].includes(reason) && !hasCanvas);
const expectFail = (reason === "fail") ||
(reason === "fail-with-canvas" && hasCanvas) ||
Expand Down
1 change: 0 additions & 1 deletion test/web-platform-tests/to-run.yaml
Expand Up @@ -985,7 +985,6 @@ Create-Secure-extensions-empty.any.html: [timeout, Buggy test as the test does n
Create-on-worker-shutdown.any.html: [fail, Needs Worker implementation]
cookies/006.html?wss: [fail, Unknown]
cookies/third-party-cookie-accepted.https.html: [fail, 'https://github.com/salesforce/tough-cookie/issues/80']
interfaces/WebSocket/close/close-basic.html*: [mutates-globals]
interfaces/WebSocket/close/close-connecting.html*: [fail, Potentially buggy test as Chrome fails it too]
remove-own-iframe-during-onerror.window.html: [timeout, iframe.srcdoc not implemented]
stream-tentative/*: [timeout, Not implemented]
Expand Down

0 comments on commit 6928d6d

Please sign in to comment.