HashChangeEvent and PopStateEvent should no longer bubble

See: whatwg/html@85e1e72
jsdom · Jul 25, 2018 · 2761d3c · 2761d3c
1 parent f1270e7
commit 2761d3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/jsdom/living/window/SessionHistory.js b/lib/jsdom/living/window/SessionHistory.js
@@ -144,7 +144,7 @@ class SessionHistory {
       this._windowImpl._dispatch(PopStateEvent.createImpl([
         "popstate",
         {
-          bubbles: true,
+          bubbles: false,
           state
         }
       ], {
@@ -156,7 +156,7 @@ class SessionHistory {
       this._windowImpl._dispatch(HashChangeEvent.createImpl([
         "hashchange",
         {
-          bubbles: true,
+          bubbles: false,
           oldURL: whatwgURL.serializeURL(oldURL),
           newURL: whatwgURL.serializeURL(newURL)
         }

diff --git a/test/to-port-to-wpts/history.js b/test/to-port-to-wpts/history.js
@@ -183,7 +183,7 @@ describe("history", () => {
       const state = { foo: "bar" };
 
       window.addEventListener("popstate", event => {
-        assert.strictEqual(event.bubbles, true);
+        assert.strictEqual(event.bubbles, false);
         assert.strictEqual(event.cancelable, false);
         assert.strictEqual(event.state, state);
 

diff --git a/test/to-port-to-wpts/location.js b/test/to-port-to-wpts/location.js
@@ -62,7 +62,7 @@ describe("location", () => {
         url: "http://www.example.com"
       }).defaultView;
       window.addEventListener("hashchange", event => {
-        assert.strictEqual(event.bubbles, true);
+        assert.strictEqual(event.bubbles, false);
         assert.strictEqual(event.cancelable, false);
         assert.strictEqual(event.oldURL, "http://www.example.com/");
         assert.strictEqual(event.newURL, "http://www.example.com/#foo");
@@ -85,7 +85,7 @@ describe("location", () => {
         url: "http://www.example.com"
       }).defaultView;
       window.addEventListener("hashchange", event => {
-        assert.strictEqual(event.bubbles, true);
+        assert.strictEqual(event.bubbles, false);
         assert.strictEqual(event.cancelable, false);
         assert.strictEqual(event.oldURL, "http://www.example.com/");
         assert.strictEqual(event.newURL, "http://www.example.com/#foo");