Update: Throw error if whitespace found in plugin name (fixes eslint#…

…6854)
jostrander · Aug 22, 2016 · 5aeeff6 · 5aeeff6
1 parent 0cf1d55
commit 5aeeff6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/lib/config/plugins.js b/lib/config/plugins.js
@@ -108,6 +108,16 @@ module.exports = {
             pluginNameWithoutPrefix = removePrefix(pluginNameWithoutNamespace);
         let plugin = null;
 
+        if (pluginName.indexOf(" ") >= 0) {
+            const whitespaceError = new Error("Whitespace found in plugin name eslint-plugin-" + pluginNameWithoutPrefix);
+
+            whitespaceError.messageTemplate = "whitespace-found";
+            whitespaceError.messageData = {
+                pluginName: pluginNameWithoutPrefix
+            };
+            throw whitespaceError;
+        }
+
         if (!plugins[pluginNameWithoutPrefix]) {
             try {
                 plugin = require(pluginNamespace + PLUGIN_NAME_PREFIX + pluginNameWithoutPrefix);

diff --git a/messages/whitespace-found.txt b/messages/whitespace-found.txt
@@ -0,0 +1,3 @@
+ESLint couldn't find the plugin "eslint-plugin-<%- pluginName %>". It looks like there is whitespace in the plugin name.
+
+If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
diff --git a/tests/lib/config/plugins.js b/tests/lib/config/plugins.js
@@ -82,6 +82,12 @@ describe("Plugins", function() {
             assert.deepEqual(Rules.get("example/qux"), plugin.rules.qux);
         });
 
+        it("should throw an error when a plugin has whitespace", function() {
+            assert.throws(function() {
+                StubbedPlugins.load("whitespace ");
+            }, /Whitespace found in plugin name/);
+        });
+
         it("should throw an error when a plugin doesn't exist", function() {
             assert.throws(function() {
                 StubbedPlugins.load("nonexistentplugin");