do not include customPatterns in initialPatterns

johnagan · Mar 4, 2019 · 5e5a519 · 5e5a519
1 parent 3830778
commit 5e5a519
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -83,8 +83,6 @@ new CleanWebpackPlugin({
      * Removes files once prior to Webpack compilation
      *   Not included in rebuilds (watch mode)
      *
-     * NOTE: customPatterns are included with this
-     *
      * Use !negative patterns to exclude files
      *
      * default: ['**']

diff --git a/src/clean-webpack-plugin.test.ts b/src/clean-webpack-plugin.test.ts
@@ -535,7 +535,6 @@ describe('customPatterns option', () => {
         expect(sandbox.getFileListSync(outputPathFull)).toEqual([
             '1.bundle.js',
             'bundle.js',
-            'static1.js',
         ]);
 
         createSrcBundle(1);
@@ -593,7 +592,8 @@ describe('dangerouslyAllowCleanPatternsOutsideProject option', () => {
         expect(initialOutsideFiles).toEqual(['outside-file.js']);
 
         const cleanWebpackPlugin = new CleanWebpackPlugin({
-            customPatterns: [path.join(sandbox.dir, 'build/**')],
+            // Use initialPatterns because webpack 2/3 doesn't handle errors in done lifecycle correctly
+            initialPatterns: [path.join(sandbox.dir, 'build/**')],
         });
 
         const compiler = webpack({

diff --git a/src/clean-webpack-plugin.ts b/src/clean-webpack-plugin.ts
@@ -34,8 +34,6 @@ interface Options {
      * Removes files once prior to Webpack compilation
      *   Not included in rebuilds (watch mode)
      *
-     * NOTE: customPatterns are included with this
-     *
      * Use !negative patterns to exclude files
      *
      * default: ['**']
@@ -180,7 +178,7 @@ class CleanWebpackPlugin {
 
         this.initialClean = true;
 
-        this.removeFiles([...this.initialPatterns, ...this.customPatterns]);
+        this.removeFiles(this.initialPatterns);
     }
 
     handleDone(stats: Stats) {