Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a lint rule to report error when testing promises. If a exp… #42

Merged
merged 19 commits into from
Jan 17, 2018
Merged

Introduce a lint rule to report error when testing promises. If a exp… #42

merged 19 commits into from
Jan 17, 2018

Commits on Jan 10, 2018

  1. feat: implement valid-expect-in-promise rule 

    introduce a lint rule to report error when testing promises. If a expectation is added inside a then or catch block of promise then as per jest docs,
it is mandatory to return that promise for succesfull execution of that expectation. This rule will report all such expectations where promise is not returned.
    @tushardhole
    tushardhole committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    d70d9ed View commit details
    Browse the repository at this point in the history

  2. fix: do not add the rule to recommended

    @tushardhole
    tushardhole committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    ab0f43c View commit details
    Browse the repository at this point in the history

  3. fix: do not validate await expressions for valid_expect_in_promise

    @tushardhole
    tushardhole committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    da393e0 View commit details
    Browse the repository at this point in the history

  4. fix: scenario with expect in nested then/catch

    @tushardhole
    tushardhole committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    dbba301 View commit details
    Browse the repository at this point in the history

  5. docs: updating docs for valid-expect-in-promise rule

    @tushardhole
    tushardhole committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4651b68 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. test: add failing test case

    @SimenB
    SimenB committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    5b25a69 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. fix: scenario where promise is returned later

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    8b6367d View commit details
    Browse the repository at this point in the history

  2. fix: adding more scenarios where promise is returned later

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    ede8427 View commit details
    Browse the repository at this point in the history

  3. test: adding more tests

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    8614010 View commit details
    Browse the repository at this point in the history

  4. fix: adding scenarios for non test functions

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    9abdd01 View commit details
    Browse the repository at this point in the history

  5. fix: refactor to avoid multiple execution of getTestFuncBody

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    3314dbf View commit details
    Browse the repository at this point in the history

  6. fix: scenario with arrow-short-hand-fn with implicit return statement

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    00422dd View commit details
    Browse the repository at this point in the history

  7. fix: scenario with multiline function in then block

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    1242897 View commit details
    Browse the repository at this point in the history

  8. fix: scenario with short hand arrow function in then block

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    0bd4572 View commit details
    Browse the repository at this point in the history

  9. fix: do not validate tests with done async param

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    4237828 View commit details
    Browse the repository at this point in the history

  10. fix: scenario where expect in then is preceded by return

    @tushardhole
    tushardhole committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    567b85c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. fix: duplicate warning for same promise

    @tushardhole
    tushardhole committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    5a69337 View commit details
    Browse the repository at this point in the history

  2. fix: better naming

    @tushardhole
    tushardhole committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    7e44766 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. test: better formatting

    @tushardhole
    tushardhole committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    e2dc02c View commit details
    Browse the repository at this point in the history