Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly format date #182

Merged
merged 4 commits into from Mar 13, 2018
Merged

Correctly format date #182

merged 4 commits into from Mar 13, 2018

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Mar 13, 2018 •
edited

Fixes #181

@n1ru4l n1ru4l mentioned this pull request Mar 13, 2018
Closed
@kherock
Copy link
Collaborator

kherock commented Mar 13, 2018 •
edited

This looks correct, I forgot to ensure that the string that arrived at the XML template builder was an ISO string when I was changing things in that last PR, whoops.

Also if you want to avoid casting to a Date inline there I have a getter for lastModifiedDate on the object prototype.

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Mar 13, 2018

@specialkk thanks for pointing that out, I updated it and also fixed the linting error.

@n1ru4l n1ru4l merged commit 1e152e2 into master Mar 13, 2018
@n1ru4l n1ru4l deleted the n1ru4l-patch-1 branch March 13, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kherock kherock kherock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n1ru4l @kherock