Use co-mocha for async tests #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
approved these changes
Mar 13, 2018
This improves error handling within tests so that they shouldn't time out when an assertion fails from within a callback. Server instances created within tests are also closed in finally blocks to avoid making Mocha hanging at the end. This also greatly improves the performance of bulk generation of objects by allowing 100 concurrent uploads at a time. The indefinite timeout on these long-running tests has been removed.
|
Cool, I'll merge now since it looks like we'll need to be adding some more tests pretty soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves error handling within tests so that they shouldn't time out when an assertion fails from within a callback. Server instances created within tests are also closed in finally blocks to avoid making Mocha hanging at the end.
This also greatly improves the performance of bulk generation of objects by allowing 100 concurrent uploads at a time. The indefinite timeout on these long-running tests has been removed.
edit: wooo new record of only 3:28 for total test runtime on Travis!