Merge pull request #186 from jamhall/fix-listobjects-bucket-name

Include bucket name in listObjects XML response
jamhall · Mar 15, 2018 · bc79afb · bc79afb
2 parents d69913a + 325ca7f
commit bc79afb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/lib/controllers.js b/lib/controllers.js
@@ -344,7 +344,11 @@ module.exports = function(rootDirectory, logger, indexDocument, errorDocument) {
             results.objects.length,
             req.params.bucket
           );
-          const template = templateBuilder.buildBucketQuery(options, results);
+          const template = templateBuilder.buildBucketQuery(
+            req.params.bucket,
+            options,
+            results
+          );
           buildXmlResponse(res, 200, template);
         });
       }

diff --git a/lib/xml-template-builder.js b/lib/xml-template-builder.js
@@ -29,15 +29,15 @@ exports.buildBuckets = function(buckets) {
   );
 };
 
-exports.buildBucketQuery = function(options, data) {
+exports.buildBucketQuery = function(bucketName, options, data) {
   const xml = {
     _name: "ListBucketResult",
     _attrs: { xmlns: "http://doc.s3.amazonaws.com/2006-03-01" },
     _content: [
       {
         IsTruncated: options.isTruncated || false,
         Marker: options.marker || "",
-        Name: options.bucketName,
+        Name: bucketName,
         Prefix: options.prefix || "",
         MaxKeys: options.maxKeys
       },

diff --git a/test/test.js b/test/test.js
@@ -725,6 +725,7 @@ describe("S3rver Tests", function() {
       )
     );
     const data = yield s3Client.listObjects({ Bucket: buckets[1] }).promise();
+    expect(data.Name).to.equal(buckets[1]);
     expect(data.Contents).to.have.lengthOf(testObjects.length);
   });