Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fork of supertest #118

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Switch to fork of supertest #118

merged 1 commit into from
Nov 20, 2017

Conversation

bkeepers
Copy link
Contributor

ladjs/supertest#446 should help reveal the underlying source of errors with supertest. Here's what it looks like now:

Before:

Cannot read property 'status' of undefined

After:

NetConnectNotAllowedError: Nock: Not allow net connect for "127.0.0.1:56508/slack/command"

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   72.78%   72.78%           
=======================================
  Files          28       28           
  Lines         474      474           
  Branches       65       65           
=======================================
  Hits          345      345           
  Misses        114      114           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e3aa2...2935ec7. Read the comment docs.

@bkeepers bkeepers merged commit a0f46cc into master Nov 20, 2017
@bkeepers bkeepers deleted the superfork branch November 20, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants