Merge pull request #30 from mochajs/globs

fixes globbing issues; add support for *.markdown in dirs; closes #20

README.md

@@ -65,4 +65,4 @@ MIT © Igor Shubovych
 [config]: https://github.com/DavidAnson/markdownlint#optionsconfig
 [style-folder]: https://github.com/DavidAnson/markdownlint/tree/master/style
 [test-config]: https://github.com/igorshubovych/markdownlint-cli/blob/master/test/test-config.json
-[rc-standards]: https://www.npmjs.com/package/rc#standards
+[rc-standards]: https://www.npmjs.com/package/rc#standards

markdownlint.js

@@ -41,10 +41,13 @@ function readConfiguration(args) {
 
 function prepareFileList(files) {
   files = files.map(function (file) {
-    var isDir = fs.lstatSync(file).isDirectory();
-    if (isDir) {
-      var markdownFiles = path.join(file, '**', '*.md');
-      return glob.sync(markdownFiles);
+    try {
+      if (fs.lstatSync(file).isDirectory()) {
+        return glob.sync(path.join(file, '**', '*.{md,markdown}'));
+      }
+    } catch (err) {
+      // Not a directory, not a file, may be a glob
+      return glob.sync(file);
     }
     return file;
   });

test/subdir-correct/correct.markdown

@@ -0,0 +1,26 @@
+# header
+
+## header 2
+
+text
+
+```fence
+code
+```
+
+text
+
+```fence
+$ code
+
+output
+```
+
+text
+
+```fence
+code
+code
+```
+
+text

test/subdir-correct/correct.md

@@ -0,0 +1,26 @@
+# header
+
+## header 2
+
+text
+
+```fence
+code
+```
+
+text
+
+```fence
+$ code
+
+output
+```
+
+text
+
+```fence
+code
+code
+```
+
+text

test/subdir-incorrect/incorrect.markdown

@@ -0,0 +1,28 @@
+## header 2
+# header
+
+```fence
+$ code
+```
+
+text
+
+```fence
+$ code
+```
+
+text
+
+```fence
+$ code
+$ code
+```
+
+text
+
+```fence
+$ code
+$ code
+```
+
+text

test/subdir-incorrect/incorrect.md

@@ -0,0 +1,28 @@
+## header 2
+# header
+
+```fence
+$ code
+```
+
+text
+
+```fence
+$ code
+```
+
+text
+
+```fence
+$ code
+$ code
+```
+
+text
+
+```fence
+$ code
+$ code
+```
+
+text

test/test.js

@@ -51,3 +51,33 @@ test('linting of incorrect Markdown via npm run file fails with eol', async t =>
     t.true(/\nnpm ERR! code ELIFECYCLE/.test(err.stderr));
   }
 });
+
+test('glob linting works with passing files', async t => {
+  const result = await execa('../markdownlint.js',
+    ['--config', 'test-config.json', '**/correct.md']);
+  t.true(result.stdout.length === 0);
+});
+
+test('glob linting works with failing files', async t => {
+  try {
+    await execa('../markdownlint.js',
+      ['--config', 'test-config.json', '**/.md']);
+  } catch (err) {
+    t.true(err.stderr.length > 0);
+  }
+});
+
+test('dir linting works with passing .markdown files', async t => {
+  const result = await execa('../markdownlint.js',
+    ['--config', 'test-config.json', 'subdir-correct']);
+  t.true(result.stdout.length === 0);
+});
+
+test('dir linting works with failing .markdown files', async t => {
+  try {
+    await execa('../markdownlint.js',
+      ['--config', 'test-config.json', 'subdir-incorrect']);
+  } catch (err) {
+    t.true(err.stderr.length > 0);
+  }
+});