Update dependencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryota-ka
commented
Oct 17, 2017
| created: is(Number), | ||
| creator: is(String) | ||
| }); | ||
| export function isChannel(x: any): x is Channel { |
There was a problem hiding this comment.
where が type predicate として振る舞わないので泣く泣くこうしている (isInstantMessage も同様)
ryota-ka
commented
Oct 17, 2017
| @@ -53,7 +53,7 @@ export function updateChannel(key: string, project: (x: Channel) => Channel): Ac | |||
| } | |||
|
|
|||
| export function deleteChannel(key: string): Action { | |||
| return curryDel(key); | |||
| return over(lensProp('channels'), curryDel(key)); | |||
There was a problem hiding this comment.
ここは元の実装がおかしかった疑惑がある．
ryota-ka
commented
Oct 17, 2017
| @@ -78,7 +78,7 @@ export function makeSlackBotDriver(token: string, options?: makeBotDriverOptions | |||
| const pong$: O<Timestamp<{}>> = fromEvent(socket, 'pong') | |||
| .timestamp(); | |||
|
|
|||
| const pingOutput$ = ping$.mapTo(() => socket.ping(null, {}, true)); | |||
| const pingOutput$ = ping$.mapTo(() => socket.ping(null, true, true)); | |||
There was a problem hiding this comment.
ryota-ka
commented
Oct 17, 2017
| @@ -1,4 +1,4 @@ | |||
| import * as ms from 'ms'; | |||
| import ms = require('ms'); | |||
ryota-ka
force-pushed
the
update-dependencies
branch
from
03a44da
to
703eeeb
Compare
ryota-ka
commented
Oct 17, 2017
| @@ -19,7 +22,7 @@ export class EventSource { | |||
| } | |||
|
|
|||
| selectByChannelName(name: string): Observable<IncomingMessage<Channel>> { | |||
| return this._message$.mergeMap(({event, channels}) => { | |||
| return this._message$.filter<BothPS, ChanPS>((ps: BothPS): ps is ChanPS => isChannel(ps.event.channel)).mergeMap(({event, channels}) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/ms@types/ws@types/nodems(0.7.3->2.0.0)ws(1.1.1->3.2.0)rxjs(5.0.3->5.4.3)ramda(0.22.1->0.25.0)@types/ramda(0.0.2->0.24.17)