Merge pull request #1638 from paxa1887/#1637.Using_Number.MAX_SAFE_IN…

…TEGER_throw_error fix condition, add tests for safe numbers
hapijs · Nov 11, 2018 · cebb4f3 · cebb4f3
2 parents 12a4666 + a72af2f
commit cebb4f3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/types/number/index.js b/lib/types/number/index.js
@@ -90,7 +90,7 @@ internals.Number = class extends Any {
 
         if (isNumber) {
             if (!this._flags.unsafe &&
-                (value >= Number.MAX_SAFE_INTEGER || value <= Number.MIN_SAFE_INTEGER)) {
+                (value > Number.MAX_SAFE_INTEGER || value < Number.MIN_SAFE_INTEGER)) {
                 result.errors = this.createError('number.unsafe', { value }, state, options);
             }
         }

diff --git a/test/types/number.js b/test/types/number.js
@@ -1414,6 +1414,18 @@ describe('number', () => {
         });
     });
 
+    describe('safe', () => {
+
+        it('should accept safe numbers', () => {
+
+            const t = Joi.number();
+            Helper.validate(t, [
+                [Number.MAX_SAFE_INTEGER, true, null, Number.MAX_SAFE_INTEGER],
+                [Number.MIN_SAFE_INTEGER, true, null, Number.MIN_SAFE_INTEGER]
+            ]);
+        });
+    });
+
     describe('min()', () => {
 
         it('throws when limit is not a number', () => {