Skip to content

Commit

Permalink
Remove node_modules from appveyor cache
Browse files Browse the repository at this point in the history
  • Loading branch information
@shama
shama committed Feb 21, 2016
1 parent af10401 commit 2f5499c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions appveyor.yml
View file
Expand Up @@ -27,6 +27,4 @@ build: off
matrix:
fast_finish: true
cache:
- C:\Users\appveyor\AppData\Roaming\npm\node_modules -> package.json # global npm modules
- C:\Users\appveyor\AppData\Roaming\npm-cache -> package.json # npm cache
- node_modules -> package.json # local npm modules
- node_modules -> package.json

5 comments on commit 2f5499c

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama: it seems on node.js 5.7.0 an error is thrown. Is this an issue with node.js itself?

Just noticed it today, and trying to figure out the cause.

@shama
Copy link
Member Author

@shama shama commented on 2f5499c Feb 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. That looks like a legit failure to me. We can investigate more by adding grunt test --verbose --stack.

In fact, another thing I think we should normalize is the package.json:

  • Check for "test": "grunt test --verbose --stack"
  • Check for "files": []
  • Check that "main" points to the task
  • Check for "engines": { "node": ">=0.10" }
  • Normalize license, repo and author fields (author will be going to jQuery Foundation and contributors in the future so we should probably wait on that)
  • Any other fields?

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can help doing that, as long as we have a final decision 'cause I reverted the jQuery foundation license header in grunt-contrib-internal; I thought it was a mistake since I didn't see any other info :/

@shama
Copy link
Member Author

@shama shama commented on 2f5499c Feb 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Grunt is in progress of transitioning to the jQuery foundation: gruntjs/grunt#1404

There are some outstanding issues to address before we can make the transition at this time. But we'll get there eventually.

Thanks for the help on this!

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama: can you make your changes in one of the plugins and ping me? Then I will backport them for all plugins I have push rights.

Please sign in to comment.