Fix audited packages, support Node 10, drop support for Node 4 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
approved these changes
Oct 19, 2018
BREAKING CHANGE: This removes support for Node 4 as well as for bundling the library for the browser without compilation.
markowsiak
force-pushed
the
mo-support-node-10
branch
from
846d5ee
to
16800e3
Compare
|
Agreed @jkrems 👍 commit message updated. |
jkrems
approved these changes
Oct 29, 2018
lenovouser
reviewed
Nov 7, 2018
| @@ -17,6 +17,10 @@ | |||
| "test": "mocha", | |||
| "posttest": "nlm verify" | |||
| }, | |||
| "engines": { | |||
| "yarn": "0.0.0", | |||
There was a problem hiding this comment.
This makes this module incompatible with yarn
There was a problem hiding this comment.
Yarn unfortunately has some very unique ideas about how to interpret the engines field. We use it here to clearly mark this project as using package-lock. If you're using it in your project with yarn, I'd suggest adding something like this to your .npmrc (project-level):
ignore-engines=trueI hope that helps unblock you but we'll also look into ways to still mark this library as non-yarn-using while supporting people that use yarn's default engines handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.