Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE and remove license header from source files #1960

Merged
merged 1 commit into from Jun 10, 2019

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 7, 2019
@@ -1,6 +1,6 @@
MIT License

Copyright (c) Facebook, Inc. and its affiliates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* LICENSE file in the root directory of this source tree.
*
* @flow strict
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the source code for a couple of other projects under LF (Node.js, ESLint, esprima) and they just just have LICENSE at the root of the project and no license headers inside the source code.

Those headers add some inconvenience in the development process e.g. new contributors forget to add them, old PRs contains an old version of the license text, it's harder to diff and revert old commits, etc.

Plus they effectively double up the size of NPM package:

npm notice package size:  483.3 kB
npm notice unpacked size: 3.6 MB

VS

npm notice package size:  237.5 kB
npm notice unpacked size: 1.7 MB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus they effectively double up the size of NPM package:

I mad mistake during measurement, in reality, it was around ~100 kB difference unpacked.

@IvanGoncharov
Copy link
Member Author

@leebyron As a followup from last WG I created this PR.
I want to release 14.4.0 next week so it would be great if we can include this update copyright and relese NPM package that is > 50% smaller.
Can you please review it?

@caniszczyk
Copy link

sorry can you just switch to plain old BSD-3? no need to switch to MIT, keep everything the same license

@IvanGoncharov
Copy link
Member Author

@caniszczyk Thanks for the review 👍

sorry can you just switch to plain old BSD-3? no need to switch to MIT, keep everything the same license

At the moment, almost all projects under GraphQL organization are licensed as MIT:
https://github.com/graphql/libgraphqlparser/blob/master/LICENSE
https://github.com/graphql/graphql-relay-js/blob/master/LICENSE
https://github.com/graphql/dataloader/blob/master/LICENSE
https://github.com/graphql/faq/blob/master/LICENSE
https://github.com/graphql/graphiql/blob/master/LICENSE
https://github.com/graphql/graphql-js/blob/master/LICENSE

Only two repos are under BSD+Patents:
https://github.com/graphql/codemirror-graphql/blob/master/LICENSE
https://github.com/graphql/express-graphql/blob/master/LICENSE

And another two repo is under some strange licenses:
https://github.com/graphql/swapi-graphql/blob/master/LICENSE-examples
https://github.com/graphql/graphql-language-service/blob/master/LICENSE

Also, licenses were explicitly switched by Lee, as described here:
https://medium.com/@leeb/relicensing-the-graphql-specification-e7d07a52301b

Additionally, our reference implementation GraphQL.js and client-side framework Relay will be relicensed under the MIT license,

So it would be easier to stick with MIT since it what we already used on most of the projects (6 vs 2) and also since it was long promised to the community.

Is there any reason why we can't use MIT for GraphQL Foundation projects?

@caniszczyk
Copy link

caniszczyk commented Jun 10, 2019 via email

@IvanGoncharov
Copy link
Member Author

@caniszczyk Thanks for the quick reply 👍

Does it mean I can merge both PRs?

@caniszczyk
Copy link

caniszczyk commented Jun 10, 2019 via email

@IvanGoncharov
Copy link
Member Author

just make sure the copyright is attributed to "GraphQL Contributors"

@caniszczyk Done. Thanks for a fast review 👍

@IvanGoncharov IvanGoncharov merged commit 35c68d4 into graphql:master Jun 10, 2019
@IvanGoncharov IvanGoncharov deleted the newLicenseChanges branch June 10, 2019 21:04
@IvanGoncharov
Copy link
Member Author

IvanGoncharov commented Jun 10, 2019

@caniszczyk Can we apply the same LICENSE changes to all other projects under this organization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants