Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix out of range return check for charCodeAt in lexer (NaN instead of null) #1772

Merged
merged 3 commits into from Mar 5, 2019
Merged

fix out of range return check for charCodeAt in lexer (NaN instead of null) #1772

merged 3 commits into from Mar 5, 2019

Conversation

superhawk610
Copy link
Contributor

According to the MDN, String.prototype.charCodeAt will only ever return a number or NaN, never null.

This PR updates that check in each of the 4 places that it occurs.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@IvanGoncharov IvanGoncharov merged commit 514e7d5 into graphql:master Mar 5, 2019
@IvanGoncharov
Copy link
Member

@superhawk610 Thanks for PR 👍
Looks good and definitely improve code quality.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Mar 5, 2019
@snyk-bot snyk-bot mentioned this pull request Aug 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@superhawk610 @facebook-github-bot @IvanGoncharov