Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move coverage upload to .travis.yml #1693

Merged
merged 1 commit into from Jan 25, 2019
Merged

Move coverage upload to .travis.yml #1693

merged 1 commit into from Jan 25, 2019

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 25, 2019 •
edited

Codecov Report

Merging #1693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1693   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         214      214           
  Lines       13160    13160           
  Branches     1959     1959           
=======================================
  Hits        12867    12867           
  Misses        190      190           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf7cdd...d712299. Read the comment docs.

@IvanGoncharov IvanGoncharov force-pushed the node11Tests branch 2 times, most recently from c93dd78 to d712299 Compare January 25, 2019 16:17
mjmahone
mjmahone approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is better: thanks for making it so we can run any npm run command without needing to worry about uploads/travis specifics!

@IvanGoncharov IvanGoncharov merged commit 8cd3150 into graphql:master Jan 25, 2019
@snyk-bot snyk-bot mentioned this pull request Aug 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmahone mjmahone mjmahone approved these changes

Assignees
No one assigned
Labels
CLA Signed PR: internal 🏠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvanGoncharov @codecov-io @mjmahone @facebook-github-bot