Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable coverage on deprecated 'isValidJSValue' function #1673

Merged
merged 1 commit into from Jan 25, 2019

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jan 18, 2019
@Neitsch
Copy link

Neitsch commented Jan 18, 2019

This does not seem ready?

@IvanGoncharov
Copy link
Member Author

@IvanGoncharov I tried to disable coverage for entire file and it looks like it broke coverall not only for this PR but for all others :(
I'm trying to do understand what's happening.

@codecov-io
Copy link

Codecov Report

Merging #1673 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
+ Coverage   97.75%   97.77%   +0.02%     
==========================================
  Files         215      214       -1     
  Lines       13164    13160       -4     
  Branches     1960     1959       -1     
==========================================
- Hits        12868    12867       -1     
+ Misses        193      190       -3     
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc3faf...8049ce2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants