Move polyfills into separate dir and exclude them from coverage (#1656)

.nycrc

@@ -1,5 +1,5 @@
 {
   "include": ["src/"],
-  "exclude": [],
+  "exclude": ["src/polyfills"],
   "temp-directory": "coverage"
 }

src/execution/values.js

@@ -7,8 +7,8 @@
  * @flow strict
  */
 
+import find from '../polyfills/find';
 import { GraphQLError } from '../error/GraphQLError';
-import find from '../jsutils/find';
 import inspect from '../jsutils/inspect';
 import invariant from '../jsutils/invariant';
 import keyMap from '../jsutils/keyMap';

src/jsutils/mapValue.js

@@ -8,7 +8,7 @@
  */
 
 import type { ObjMap } from './ObjMap';
-import objectEntries from './objectEntries';
+import objectEntries from '../polyfills/objectEntries';
 
 /**
  * Creates an object map with the same keys as `map` and values generated by

src/polyfills/README.md

@@ -0,0 +1,9 @@
+Polyfills
+---------
+
+This directory contains dependency-free polyfills for ES6 & ES7 functions used
+throughout the codebase.
+
+Each polyfill should belong in its own file and be the default export.
+
+These functions are not part of the module interface and are subject to change.

src/jsutils/objectEntries.js → src/polyfills/objectEntries.js

@@ -7,7 +7,7 @@
  * @flow strict
  */
 
-import type { ObjMap } from './ObjMap';
+import type { ObjMap } from '../jsutils/ObjMap';
 
 declare function objectEntries<T>(obj: ObjMap<T>): Array<[string, T]>;
 

src/jsutils/objectValues.js → src/polyfills/objectValues.js

@@ -7,7 +7,7 @@
  * @flow strict
  */
 
-import type { ObjMap } from './ObjMap';
+import type { ObjMap } from '../jsutils/ObjMap';
 
 declare function objectValues<T>(obj: ObjMap<T>): Array<T>;
 

src/type/definition.js

@@ -7,6 +7,7 @@
  * @flow strict
  */
 
+import objectEntries from '../polyfills/objectEntries';
 import defineToJSON from '../jsutils/defineToJSON';
 import defineToStringTag from '../jsutils/defineToStringTag';
 import instanceOf from '../jsutils/instanceOf';
@@ -15,7 +16,6 @@ import invariant from '../jsutils/invariant';
 import keyMap from '../jsutils/keyMap';
 import mapValue from '../jsutils/mapValue';
 import type { ObjMap } from '../jsutils/ObjMap';
-import objectEntries from '../jsutils/objectEntries';
 import { Kind } from '../language/kinds';
 import { valueFromASTUntyped } from '../utilities/valueFromASTUntyped';
 import type {

src/type/directives.js

@@ -7,6 +7,7 @@
  * @flow strict
  */
 
+import objectEntries from '../polyfills/objectEntries';
 import type {
   GraphQLFieldConfigArgumentMap,
   GraphQLArgument,
@@ -18,7 +19,6 @@ import defineToJSON from '../jsutils/defineToJSON';
 import instanceOf from '../jsutils/instanceOf';
 import invariant from '../jsutils/invariant';
 import inspect from '../jsutils/inspect';
-import objectEntries from '../jsutils/objectEntries';
 import type { DirectiveDefinitionNode } from '../language/ast';
 import {
   DirectiveLocation,

src/type/introspection.js

@@ -7,8 +7,8 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import isInvalid from '../jsutils/isInvalid';
-import objectValues from '../jsutils/objectValues';
 import { astFromValue } from '../utilities/astFromValue';
 import { print } from '../language/printer';
 import {

src/type/scalars.js

@@ -7,9 +7,9 @@
  * @flow strict
  */
 
+import isFinite from '../polyfills/isFinite';
+import isInteger from '../polyfills/isInteger';
 import inspect from '../jsutils/inspect';
-import isFinite from '../jsutils/isFinite';
-import isInteger from '../jsutils/isInteger';
 import { GraphQLScalarType, isNamedType } from './definition';
 import { Kind } from '../language/kinds';
 

src/type/schema.js

@@ -7,6 +7,8 @@
  * @flow strict
  */
 
+import find from '../polyfills/find';
+import objectValues from '../polyfills/objectValues';
 import {
   isAbstractType,
   isObjectType,
@@ -34,10 +36,8 @@ import type { GraphQLError } from '../error/GraphQLError';
 import inspect from '../jsutils/inspect';
 import { __Schema } from './introspection';
 import defineToStringTag from '../jsutils/defineToStringTag';
-import find from '../jsutils/find';
 import instanceOf from '../jsutils/instanceOf';
 import invariant from '../jsutils/invariant';
-import objectValues from '../jsutils/objectValues';
 import type { ObjMap } from '../jsutils/ObjMap';
 
 /**

src/type/validate.js

@@ -7,6 +7,9 @@
  * @flow strict
  */
 
+import find from '../polyfills/find';
+import objectValues from '../polyfills/objectValues';
+import objectEntries from '../polyfills/objectEntries';
 import {
   isObjectType,
   isInterfaceType,
@@ -31,9 +34,6 @@ import { isIntrospectionType } from './introspection';
 import { assertSchema } from './schema';
 import type { GraphQLSchema } from './schema';
 import inspect from '../jsutils/inspect';
-import find from '../jsutils/find';
-import objectValues from '../jsutils/objectValues';
-import objectEntries from '../jsutils/objectEntries';
 import { GraphQLError } from '../error/GraphQLError';
 import type {
   ASTNode,

src/utilities/TypeInfo.js

@@ -7,6 +7,7 @@
  * @flow strict
  */
 
+import find from '../polyfills/find';
 import { Kind } from '../language/kinds';
 import {
   isObjectType,
@@ -39,7 +40,6 @@ import {
 import type { GraphQLSchema } from '../type/schema';
 import type { ASTNode, FieldNode } from '../language/ast';
 import { typeFromAST } from './typeFromAST';
-import find from '../jsutils/find';
 
 /**
  * TypeInfo is a utility class which, given a GraphQL schema, can keep track

src/utilities/astFromValue.js

@@ -9,10 +9,10 @@
 
 import { forEach, isCollection } from 'iterall';
 
+import objectValues from '../polyfills/objectValues';
 import inspect from '../jsutils/inspect';
 import isNullish from '../jsutils/isNullish';
 import isInvalid from '../jsutils/isInvalid';
-import objectValues from '../jsutils/objectValues';
 import type { ValueNode } from '../language/ast';
 import { Kind } from '../language/kinds';
 import type { GraphQLInputType } from '../type/definition';

src/utilities/buildASTSchema.js

@@ -7,10 +7,10 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import invariant from '../jsutils/invariant';
 import keyMap from '../jsutils/keyMap';
 import keyValMap from '../jsutils/keyValMap';
-import objectValues from '../jsutils/objectValues';
 import type { ObjMap } from '../jsutils/ObjMap';
 import { valueFromAST } from './valueFromAST';
 import { assertValidSDL } from '../validation/validate';

src/utilities/coerceValue.js

@@ -8,10 +8,10 @@
  */
 
 import { forEach, isCollection } from 'iterall';
+import objectValues from '../polyfills/objectValues';
 import inspect from '../jsutils/inspect';
 import isInvalid from '../jsutils/isInvalid';
 import orList from '../jsutils/orList';
-import objectValues from '../jsutils/objectValues';
 import suggestionList from '../jsutils/suggestionList';
 import { GraphQLError } from '../error/GraphQLError';
 import type { ASTNode } from '../language/ast';

src/utilities/extendSchema.js

@@ -7,10 +7,10 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import invariant from '../jsutils/invariant';
 import mapValue from '../jsutils/mapValue';
 import keyValMap from '../jsutils/keyValMap';
-import objectValues from '../jsutils/objectValues';
 import { ASTDefinitionBuilder } from './buildASTSchema';
 import { assertValidSDLExtension } from '../validation/validate';
 import { assertSchema, GraphQLSchema } from '../type/schema';

src/utilities/findBreakingChanges.js

@@ -7,6 +7,7 @@
  * @flow strict
  */
 
+import find from '../polyfills/find';
 import {
   isScalarType,
   isObjectType,
@@ -30,7 +31,6 @@ import type {
 
 import type { GraphQLDirective } from '../type/directives';
 import type { GraphQLSchema } from '../type/schema';
-import find from '../jsutils/find';
 import keyMap from '../jsutils/keyMap';
 
 import type { ObjMap } from '../jsutils/ObjMap';

src/utilities/lexicographicSortSchema.js

@@ -7,9 +7,9 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import type { ObjMap } from '../jsutils/ObjMap';
 import keyValMap from '../jsutils/keyValMap';
-import objectValues from '../jsutils/objectValues';
 import { GraphQLSchema } from '../type/schema';
 import { GraphQLDirective } from '../type/directives';
 import type { GraphQLNamedType } from '../type/definition';

src/utilities/schemaPrinter.js

@@ -7,9 +7,9 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import isNullish from '../jsutils/isNullish';
 import isInvalid from '../jsutils/isInvalid';
-import objectValues from '../jsutils/objectValues';
 import { astFromValue } from '../utilities/astFromValue';
 import { print } from '../language/printer';
 import type { GraphQLSchema } from '../type/schema';

src/utilities/valueFromAST.js

@@ -7,9 +7,9 @@
  * @flow strict
  */
 
+import objectValues from '../polyfills/objectValues';
 import keyMap from '../jsutils/keyMap';
 import isInvalid from '../jsutils/isInvalid';
-import objectValues from '../jsutils/objectValues';
 import type { ObjMap } from '../jsutils/ObjMap';
 import { Kind } from '../language/kinds';
 import {

src/validation/rules/OverlappingFieldsCanBeMerged.js

@@ -7,12 +7,12 @@
  * @flow strict
  */
 
+import find from '../../polyfills/find';
+import objectEntries from '../../polyfills/objectEntries';
 import type { ValidationContext } from '../ValidationContext';
 import { GraphQLError } from '../../error/GraphQLError';
 import inspect from '../../jsutils/inspect';
-import find from '../../jsutils/find';
 import type { ObjMap } from '../../jsutils/ObjMap';
-import objectEntries from '../../jsutils/objectEntries';
 import type {
   SelectionSetNode,
   FieldNode,

src/validation/rules/ValuesOfCorrectType.js

@@ -7,6 +7,7 @@
  * @flow strict
  */
 
+import objectValues from '../../polyfills/objectValues';
 import type { ValidationContext } from '../ValidationContext';
 import { GraphQLError } from '../../error/GraphQLError';
 import type { ValueNode } from '../../language/ast';
@@ -27,7 +28,6 @@ import inspect from '../../jsutils/inspect';
 import isInvalid from '../../jsutils/isInvalid';
 import keyMap from '../../jsutils/keyMap';
 import orList from '../../jsutils/orList';
-import objectValues from '../../jsutils/objectValues';
 import suggestionList from '../../jsutils/suggestionList';
 
 export function badValueMessage(