chore: start testing against Node 10 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 10 10
Lines 331 331
Branches 22 22
=======================================
Hits 320 320
Misses 11 11Continue to review full report at Codecov.
|
jinwoo
approved these changes
May 20, 2018
| user: node | ||
| <<: *unit_tests | ||
|
|
||
| publish_npm: | ||
| docker: | ||
| - image: node:8 | ||
| - image: node:10 |
There was a problem hiding this comment.
It wouldn't matter much but isn't it still better to publish with 8 because it's LTS?
There was a problem hiding this comment.
Modules published with 10 should work with other versions of Node too, so is there a tangible difference here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.