Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: start testing against Node 10 #157

Merged
merged 1 commit into from May 21, 2018
Merged

chore: start testing against Node 10 #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -27,13 +27,13 @@ workflows:
filters: *release_tags
- node8:
filters: *release_tags
- node9:
- node10:
filters: *release_tags
- publish_npm:
requires:
- node6
- node8
- node9
- node10
filters:
branches:
ignore: /.*/
Expand All @@ -50,15 +50,15 @@ jobs:
- image: node:8
user: node
<<: *unit_tests
node9:
node10:
docker:
- image: node:9
- image: node:10
user: node
<<: *unit_tests

publish_npm:
docker:
- image: node:8
- image: node:10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't matter much but isn't it still better to publish with 8 because it's LTS?

Copy link
Contributor Author

@ofrobots ofrobots May 20, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules published with 10 should work with other versions of Node too, so is there a tangible difference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. LGTM.

user: node
steps:
- checkout
Expand Down