Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): bump version for 0.8.0 #187

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

ofrobots
Copy link
Contributor

release notes


This is a release with breaking changes. We no longer set the esModuleInterop and allowSyntheticDefaultImports in the default TypeScript config. These might be reasonable configurations for end-user application code, but for libraries these can be problematic. TypeScript users of such libraries must have these flags set as well for compilation to succeed. For example: googleapis/google-auth-library-nodejs#381.

There are two ways to deal with this breaking change:

  • (recommended) change code using synthetic imports (import fs from 'fs') back to using old style imports (import * as fs from 'fs').
  • Add "esModuleInterop": true to your local tsconfig.json.

Sorry for the churn.

Commits

@ofrobots ofrobots requested review from JustinBeckwith and a team July 12, 2018 01:00
@codecov-io
Copy link

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          12       12           
  Lines         652      652           
  Branches       55       55           
=======================================
  Hits          640      640           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92f876...efc5cfd. Read the comment docs.

@ofrobots ofrobots merged commit 82ecc4e into google:master Jul 12, 2018
@ofrobots ofrobots deleted the release-0.8.0 branch July 12, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants