New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not fix format errors with --dry-run #171
Conversation
Also added more tests.
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=========================================
+ Coverage 97.21% 99.1% +1.89%
=========================================
Files 10 10
Lines 395 449 +54
Branches 28 29 +1
=========================================
+ Hits 384 445 +61
+ Misses 11 4 -7
Continue to review full report at Codecov.
|
}, | ||
async () => { | ||
const okay = await format.format(OPTIONS); | ||
t.is(okay, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t.true(...)
?
test/test-format.ts
Outdated
}, | ||
async () => { | ||
const okay = await format.format(OPTIONS); | ||
t.is(okay, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t.false(...)
?
fs.readFileSync(path.join(fixturesDir, 'a.ts'), 'utf8'); | ||
t.deepEqual(contents, BAD_CODE); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. New line.
Also added more tests.