Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELATED: RAIL-3383 - Fix live reload issue #1394

Merged
merged 1 commit into from May 21, 2021
Merged

RELATED: RAIL-3383 - Fix live reload issue #1394

merged 1 commit into from May 21, 2021
+2 −2

Conversation

lupko
Copy link
Contributor

@lupko lupko commented May 21, 2021

JIRA: RAIL-3383

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended test BackstopJS tests
extended check sonar SonarQube tests

PR Checklist

@lupko
Fix live reload issue
da0a299 
-  Due to bug in webpack dev server. See webpack/webpack-dev-server#3271

JIRA: RAIL-3383
@gdgate
Copy link
Contributor

gdgate commented May 21, 2021

Build in pipeline check aborted.

no23reason
no23reason approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@no23reason no23reason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@no23reason no23reason added the merge Trigger Zuul merge pipeline label May 21, 2021
@gdgate
Copy link
Contributor

gdgate commented May 21, 2021

Build in pipeline check aborted.

@yenkins
Copy link

yenkins commented May 21, 2021

Sonar scan result

  • No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR1394

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@gdgate gdgate removed the merge Trigger Zuul merge pipeline label May 21, 2021
@gdgate gdgate merged commit e1ca1cc into gooddata:master May 21, 2021
@gdgate
Copy link
Contributor

gdgate commented May 21, 2021

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no23reason no23reason no23reason approved these changes

@kandl kandl Awaiting requested review from kandl kandl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lupko @gdgate @yenkins @no23reason